-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser hangs when selecting a lot of users in admin-settings #9048
Comments
@kulmann @janackermann we need to see what is feasible. |
We re-fetch each user after the operation to ensure the data is up to date with the server. We could skip that, which would reduce the amount of outgoing requests by half. Instead we could simply re-load the users list. The only drawback I see here: the current selection gets lost. @kulmann What do you think? Edit: Nevermind, I think I misunderstood the issue. The issue is that the options in the dropdown are not selectable because the browser hangs, right? The screenshots are way to small to see anything unfortunately. |
@JammingBen we also fetch each user individually (because we need to expand the drive data) upon selection. So things are going crazy even before any batch action is triggered. Currently thinking about limiting the number of listed users to some amount (100? 200?) and enforce filtering with this. Maybe even show an empty list until filters have been applied. |
True... although it makes me wonder why the dropdown-selection in the modal does not work after all users have been selected successfully 🤔 Either way, 1000+ rows per page without any pagination or lazy loading probably break the page under any circumstance. |
Exactly, we've talked a long while ago about server-side pagination, but not been implemented... Client-side pagination is the way to go for now IHMO |
yes, lets try a client side pagination / limit as temporary workaround with 200 max selected items. |
@tbsbdr does this applies to all tables in admin-settings-app ? I vote for yes |
Yes, please in a consistent way for all three that we have. |
@tbsbdr talked with involved web team members -> 50 items per page seems to be quite reasonable |
Not technically fixed, but mitigated by #9119, so I'm closing here. |
Error description
Browser hangs.
Steps to reproduce
Steps to reproduce the behavior:
Expected behavior
All users can be deactivated by batch.
Actual behavior
All users were selected after a long wait. However, the NO could not be clicked.
Additional context
Epic says that the deployment is not yet complete, but the feature is available and also usable:
With smaller number (class with about 30 users) you could do the batch processing to deactivate and also to activate the login.
Comment
Browser crashes are annoying, but here the system was really challenged. However, I suspect that the instance 0183 itself (i.e. not only my browser frontend) was also damaged by this, because uploads of files failed afterwards (message for this is "unknown error"). The two screenshots with the filename Screenshot*.png in the attachment of this ticket could not be uploaded on 0183 anymore. The upload on instance 0146, on the other hand, worked.
The text was updated successfully, but these errors were encountered: