Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password field can't be empty message #8521

Closed
ChrisEdS opened this issue Mar 1, 2023 · 1 comment · Fixed by #8864
Closed

Password field can't be empty message #8521

ChrisEdS opened this issue Mar 1, 2023 · 1 comment · Fixed by #8864
Assignees
Labels
Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task

Comments

@ChrisEdS
Copy link

ChrisEdS commented Mar 1, 2023

Steps to reproduce

  1. Create a public link
  2. Add a password
  3. Type in a password

Expected behaviour

Password field can't be empty message disappears when a password is set (when I start typing a password)

Actual behaviour

Password field can't be empty stays forever

image

@JammingBen JammingBen added the Category:Enhancement Add new functionality label Mar 8, 2023
@kulmann kulmann added the Topic:good-first-issue beginner friendly task label Mar 29, 2023
@lookacat lookacat self-assigned this Apr 19, 2023
@kulmann
Copy link
Member

kulmann commented Apr 19, 2023

In order to make this issue actionable:

  • for consistency with all other modals we should not show the empty password warning/error initially when the modal opens.
  • the error message should be red (= error message style)
  • like stated in the issue description the error message should go away as soon as the input fields holds at least one character

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants