Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Consistent Trashbin navigation #8517

Closed
5 tasks
exalate-issue-sync bot opened this issue Mar 1, 2023 · 2 comments · Fixed by #8515
Closed
5 tasks

[Web] Consistent Trashbin navigation #8517

exalate-issue-sync bot opened this issue Mar 1, 2023 · 2 comments · Fixed by #8515
Labels

Comments

@exalate-issue-sync
Copy link

Description

User Stories

  • As a user I want a consistent way to navigate between personal and Space Trashbins.

Value

Acceptance Criteria

  • Add Root-level in Trashbin: click on trashbin lists all spaces (incl. personal) the user is a member of

    • Colums at rootlavel are:
      • Space Icon (Generic Space icon for project spaces, folder-icon for personal-space)
      • Space Name
    • No Contextmenu
    • No Checkbox
    • No right sidebar
    • On click of one of the Root-Level Elements, navigate to the respective Space-Trashbin (Deleted Files > Marketing or Deleted Files > Personal)
    • Breadcrumb shows "Deleted Files"
    • On Trashbin-root-level there is no "Empty Trashbin" Button (users can't empty all trahsbins at once)
    • Order of list items: Peronal always first, the all the project spaces
    • name column sortable (like we have it in other file views), but always keep Personal on top
    • add filter field for filtering by name (only client side filtering)
  • Click on left sidebar "Deleted Files" Navigates to the root level (not to the "Personal" Trashbin)

  • Note: Project Space contextmeun Item "Deleted Files" navigates into the trash that belongs to the Space (unchanged behaviour)

Definition of ready

[ ] everybody needs to understand the value written in the user story
[ ] acceptance criteria has to be defined
[ ] all dependencies of the user story need to be identified
[ ] feature should be seen from an end user perspective
[ ] user story has to be estimated
[ ] story points need to be less then 20

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] code review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@exalate-issue-sync
Copy link
Author

Tobias Baader commented: If backend is oc10 or if you have no project spaces:

  • click on "Deleted Files" navigates directly into the "Personal" Trashbin

@exalate-issue-sync
Copy link
Author

Benedikt Kulmann commented: More precise: the /files/trash route always navigates to the new view. The view checks if there is only 1 space -> triggers a route change to that specific trash page. If more than 1 space -> stay on same route and render the view. This solution doesn't care about which backend you have and incidentally keeps the oc10 behaviour intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants