-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show file upload speed #8166
Comments
@kulmann @JammingBen @fschade Could our upload client provide that metric? |
@Pro100x3mal thanks for your input. Can you explain what you want to see? I could think of:
or do you want to see realtime the current upload speed while uploading? |
@fschade i want to see realtime the current upload speed while uploading |
Tell me, are you planning to add this option in the next release? |
@Pro100x3mal, from reading your initial request it is not clear for me what you want to see, is it "estimated time until upload is completed", literally "bytes that are being transferred this very second", or something else? Could you provide a link or screenshots to an implementation you already know, or a simple mockup on how the information should be displayed? 😉 To answer your question: Please note that there is already a web release being prepared which first needs to be brought to the oCIS repository and will be released with the next oCIS release (assuming you'd want to use an official release rather than building the application from scratch on the current master). There's also a product backlog and features scheduled to be worked on, so I'd ask you to be a bit patient - your request, while valid, is not necessarily a top priority (feel free to provide input if we're missing something on why it should be), and such a feature, including more ironing out of requirements, as pointed out above, as well as actual implementation and automated tests and maybe some user testing, take time. You're of course welcome to contribute e.g. a working prototype 🙂 The library we're using, uppy.oi, seems to have some util function that could potentially be used to achieve the goal. |
@pascalwengerter @tbsbdr |
There is an issue with current time calculation (and Nextcloud one too) as when upload speed is not stable - the time is moving awkward instead of recalculating on mean speed. So the tooltip data should be carefully thought of. |
@Pro100x3mal @mamay I've drafted something here: #8187 (comment) @mamay do you have any idea of what "carefully thinking of current time calculation" could look like? 🙂 Also, please note that the issue (and corresponding PR) target the display of current upload speed, if you find awkward moving of the progress bar to be an issue in this repo please open a separate ticket! |
There are a few questions here:
Personally I see all the estimates lying in any conditions except stable ones (except Nextcloud, its the worst I've experienced), some are better (the standard file manager ones. |
I just gave #8187 a try. Feels quite good to me. Regarding your questions some context: For "everything upload related" we rely on uppy.io including the upload speed calculation which the linked PR introduces. They calculate an average upload speed. That being said:
We can only show the average speed. The lib doesn't provide the current bandwidth utilization.
At the moment the estimated remaining upload time is simply calculated like this: Could you share your ideas for upload ETA calculation in a new issue? I think the ETA calculation is out of scope for this particular issue here. An easy first improvement could be that we use the remaining bytes and the average speed to calculate the remaining time. What do you think, would that be sufficient for your use case (in theory, obviously needs to be tried out when we have it)? |
Maybe we should post this to uppy.io, to get everything done in upstream? |
Can't hurt I suppose 🙂 from what I've witnessed they're always open for suggestions (and have given the topic some thought already I would assume), but let's see! |
Add the ability to display the upload speed in the files extension. Perhaps as a separate parameter in the settings. I want to switch from nextcloud to ocis. It is important for me to see in the web interface the speed with which I upload files to my cloud. How can I see her?
The text was updated successfully, but these errors were encountered: