Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Mail address is valid but will be marked as invalid in user view #7806

Closed
ChrisEdS opened this issue Oct 16, 2022 · 6 comments · Fixed by #7894
Closed

E-Mail address is valid but will be marked as invalid in user view #7806

ChrisEdS opened this issue Oct 16, 2022 · 6 comments · Fixed by #7894
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@ChrisEdS
Copy link

ChrisEdS commented Oct 16, 2022

Steps to reproduce

  1. Create a new user
  2. Add a wrong email address
  3. Change to valid email address

Expected behaviour

The e-mail is seen as valid if it's valid immediately (ex. validate upon keystroke)

Actual behaviour

image

Screenshot.000842.mp4

You have to click outside the field to get rid of the message

Expected behaviour

validation should take place instantly (not only with click-outside of the field.)

Environment general

Backend (ownCloud Core or Infinite Scale):
oCIS

Environment ownCloud Infinite Scale

Version:
2.0.0 Beta 8
Updated from an older Infinite Scale or fresh install:
Fresh

@tbsbdr
Copy link
Contributor

tbsbdr commented Oct 17, 2022

Refined initial post, added Video.

thx @ChrisEdS for reporting 👍

@tbsbdr tbsbdr added Priority:p4-low Low priority Type:Bug Something isn't working Priority:p3-medium Normal priority and removed Priority:p4-low Low priority labels Oct 17, 2022
@AlexAndBear
Copy link
Contributor

@tbsbdr IHMO we had talked about that and you was against the 'on typing validation' because as the user starts to type he would have shown an error message, because not valid. Has this mind changed?

@kulmann
Copy link
Member

kulmann commented Oct 19, 2022

UX is tricky here. We could switch to valid state during typing and to invalid state only on leaving the form field. What do you think?

@ChrisEdS
Copy link
Author

Make sense.

@AlexAndBear AlexAndBear self-assigned this Oct 19, 2022
@AlexAndBear
Copy link
Contributor

@kulmann agree, on it

@tbsbdr
Copy link
Contributor

tbsbdr commented Oct 21, 2022

@tbsbdr IHMO we had talked about that and you was against the 'on typing validation' because as the user starts to type he would have shown an error message, because not valid. Has this mind changed?

Not 100% sure, but if you ask me I'd recommend the following:

  1. If we are in a non-invalid state, 'on typing validation' is bad ux as if gives immediate negative feedback before the user finished her input.
  2. If we are already in an invalid state, 'on typing validation' is best as it gives immediate positive feedback if the user has reached a valid state. 'on leaving form validation' is second-best solution in this scenario imo.

Sorry if you already had that in mind and I talked it out wrongly!

Expected behaviour - Example:

Screenshot.000870.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants