Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up building share indicators #7721

Closed
exalate-issue-sync bot opened this issue Sep 30, 2022 · 0 comments · Fixed by #8349
Closed

Speed up building share indicators #7721

exalate-issue-sync bot opened this issue Sep 30, 2022 · 0 comments · Fixed by #8349
Labels
Type:Story User Story

Comments

@exalate-issue-sync
Copy link

Description

The share indicators currently block loading the view for a pretty long time. Needs to be improved.

User Stories

  • As a user I want file listings to load as fast as possible, so that I can fulfill my tasks quickly.

Value

Speedy UI.

Acceptance Criteria

  • setting share indicators in the store should not cause re-rendering of the entire files table (at the moment it sets the entire files state in the store again instead of modifying individual files in the list)
  • share indicators only need the share types of parent nodes, not the exact list of shares (payload is just a few integers instead of a potentially large list of shares). At the moment we build a shares tree in the store which contains much more information than needed. A propfind with depth=0 on all parent nodes would be sufficient.

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] codre review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants