Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space viewer can see delete- and restore-actions in space trashbin #7702

Closed
JammingBen opened this issue Sep 28, 2022 · 2 comments · Fixed by #7768
Closed

Space viewer can see delete- and restore-actions in space trashbin #7702

JammingBen opened this issue Sep 28, 2022 · 2 comments · Fixed by #7768
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@JammingBen
Copy link
Contributor

Steps to reproduce

  1. As space manager, invite user test to a space
  2. As space manager, delete a file in the space so it appears in the space trashbin
  3. As user test, navigate to the space trashbin
  4. Select the deleted file

Expected behaviour

The user should not see delete- and restore-actions.

Actual behaviour

The user sees the delete- and restore-actions.

@JammingBen JammingBen added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Sep 28, 2022
@JammingBen
Copy link
Contributor Author

@tbsbdr Am I right about the expected behavior here? Or should the trashbin be hidden completely from the user? Also, what should a space editor be able to do in this case?

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 28, 2022

your bug description is legit.

if you are a read only-member, you should not see the delete/restore options as those are write-actions (kind of..)

trashed files should be visible withini the trashbin to users who have access to those files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants