Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict selection "keep both" for folders overwrites content when using Firefox #7680

Closed
individual-it opened this issue Sep 23, 2022 · 3 comments · Fixed by #7724
Closed
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@individual-it
Copy link
Member

Steps to reproduce

  1. start web with ocis (both current master)
  2. create a folder f1
  3. upload a folder with the same name
  4. in conflict dialog select "keep both"

Expected behaviour

the new folder should be named f1 (2)

Actual behaviour

the folder is overwritten

Environment general

Operating system:
Ubuntu 22
Backend (ownCloud Core or Infinite Scale):
ocis

Environment ownCloud Infinite Scale

Version:
commit ca66a9f7516734e7a3c64074d37f266dd90f702f
Updated from an older Infinite Scale or fresh install:
fresh
Where did you install Infinite Scale from:
git

Client configuration

Browser:
FF 104.0.2 (64-bit)
Chrome works fine
Operating system:
Ubuntu 22

Logs

Browser log

MKCOLhttps://localhost:9200/remote.php/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157$e256fd28-0fcc-4d4f-8f76-98c920c7dd44/f1/
[HTTP/1.1 405 Method Not Allowed 213ms]

Error: The resource you tried to create already exists
    r https://localhost:9200/js/chunks/vendor-b5f623a3.js:136
    buildHttpErrorFromDavResponse https://localhost:9200/js/chunks/vendor-b5f623a3.js:136
    createFolder https://localhost:9200/js/chunks/vendor-b5f623a3.js:136
    promise callback*createFolder https://localhost:9200/js/chunks/vendor-b5f623a3.js:136
    vt https://localhost:9200/js/web-app-files-06301145.js:1
    handleUppyFileUpload https://localhost:9200/js/web-app-files-06301145.js:1
    displayOverwriteDialog https://localhost:9200/js/web-app-files-06301145.js:1
    onFilesSelected https://localhost:9200/js/web-app-files-06301145.js:1
    publish https://localhost:9200/js/chunks/vendor-b5f623a3.js:12
    publish https://localhost:9200/js/chunks/vendor-b5f623a3.js:12
    publish https://localhost:9200/js/web-runtime-1e168de2.js:1
    addFiles https://localhost:9200/js/web-runtime-1e168de2.js:1
    handleDrop https://localhost:9200/js/chunks/vendor-b5f623a3.js:147
    getFile https://localhost:9200/js/chunks/vendor-b5f623a3.js:147
    getFile https://localhost:9200/js/chunks/vendor-b5f623a3.js:147
    p7 https://localhost:9200/js/chunks/vendor-b5f623a3.js:147
    p7 https://localhost:9200/js/chunks/vendor-b5f623a3.js:147
    f7 https://localhost:9200/js/chunks/vendor-b5f623a3.js:147
    f7 https://localhost:9200/js/chunks/vendor-b5f623a3.js:147
    f7 https://localhost:9200/js/chunks/vendor-b5f623a3.js:147
web-app-files-06301145.js:1:101034

image

@individual-it individual-it added the Type:Bug Something isn't working label Sep 23, 2022
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label Sep 23, 2022
@JammingBen
Copy link
Contributor

JammingBen commented Sep 28, 2022

Note: It happens when uploading via the "Upload"-menu, but not via Drag&Drop.

This is due to the reason that the relativePath property has a leading slash when resources are dropped, but not when selected via menu. This "issue" originates from the browser (or Uppy, I'm not 100% sure).

Not only the "Keep both" option is affected, but also "Skip".

@individual-it
Copy link
Member Author

@JammingBen it happened for me also with Drag&Drop

@JammingBen
Copy link
Contributor

@JammingBen it happened for me also with Drag&Drop

Oh indeed. Chrome works with Drag&Drop, FF is broken either way. I assume the missing relativePath is still the issue, but that needs investigation.

@lookacat That's the issue I was talking about yesterday. However, as I already said, it needs to wait for the Drive-Alias-PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants