Shared with a group and a member of this group resource appears as 2 shares in "Shared with me"

[elizavetaRa]

Steps to reproduce

1. Share resource with a group
2. Share resource with user who is group member
3. As sharee go to "Shared with me" section

Expected behaviour

Share appears as one, share indicators show user and group

Actual behaviour

Share appears as 2 shares

[elizavetaRa]

@kulmann

[elizavetaRa]

@kulmann Found the problem. The backend request inpackages/web-app-files/src/services/folder/loaderSharedWithMe.tsreturns shares in random order. Whenever the group share and user of this group share are next to each other, they get merged into one in addSharedWithToShares. But when not, it doesn't happen. Is the returned shares list supposed to be sorted by path in the backend? Then it would be a backend bug, otherwise needs sorting before addSharedWithToShares

[kulmann]

@kulmann Found the problem. The backend request inpackages/web-app-files/src/services/folder/loaderSharedWithMe.tsreturns shares in random order. Whenever the group share and user of this group share are next to each other, they get merged into one in addSharedWithToShares. But when not, it doesn't happen. Is the returned shares list supposed to be sorted by path in the backend? Then it would be a backend bug, otherwise needs sorting before addSharedWithToShares

Good that you found it, thank you for digging into it 💪 The backend is not supposed to sort anything at the moment. We're still at sorting only happens in the client.

[elizavetaRa]

@kulmann we have a fix for it, do you want a pr? cernbox@cb6d25a

[kulmann]

@kulmann we have a fix for it, do you want a pr? cernbox@cb6d25a

PR would be awesome, thank you!