Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose error-avoiding filename on new file creation #7539

Closed
hurradieweltgehtunter opened this issue Aug 29, 2022 · 2 comments · Fixed by #7555
Closed

Propose error-avoiding filename on new file creation #7539

hurradieweltgehtunter opened this issue Aug 29, 2022 · 2 comments · Fixed by #7555
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@hurradieweltgehtunter
Copy link
Contributor

Steps to reproduce

  1. Click on button New -> text file
  2. Do not alter proposed filename ("New file.txt")
  3. Hit "Create"
  4. Click again on button New -> text file

Expected behaviour

The current behaviour is not wrong but the user experience could be improved if the proposed filename would be "New file(2).txt" thus avoiding displaying an error.

Actual behaviour

Error message shows "New file.txt already exists"

grafik

Environment general

Operating system: https://ocis.ocis-wopi.latest.owncloud.works

@kulmann
Copy link
Member

kulmann commented Aug 29, 2022

Good idea! We have the same logic anyway when the user chose "keep both" in a copy/move conflict situation. Could be reused here.

@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Aug 29, 2022
@AlexAndBear
Copy link
Contributor

Fair enough, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants