Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck after session expired #7453

Closed
hurradieweltgehtunter opened this issue Aug 16, 2022 · 4 comments
Closed

Stuck after session expired #7453

hurradieweltgehtunter opened this issue Aug 16, 2022 · 4 comments
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@hurradieweltgehtunter
Copy link
Contributor

Steps to reproduce

  1. Log in
  2. Wait until session expires
  3. Following screen appears:

Bildschirmfoto 2022-08-16 um 09 02 15

  1. Click on "exit" as suggested

Expected behaviour

Two options:

  • Auto-forward to login screen without this message. I think this is the most common behaviour, I was surprised that the mentioned message showed up at all.

But maybe this is a required step so second option:

  • Show this message but make the "exit" link an actual link. Currently it seems it's just an anchor:
    <a id="exitAnchor">exit</a>

Actual behaviour

  1. Nothing happens, "exit" is a link without target.

Environment general

https://ocis.ocis-wopi.latest.owncloud.works

@kulmann
Copy link
Contributor

kulmann commented Aug 16, 2022

Apart from the reported bug, what do you mean by wait until session expires? As we have token renewal in place this should never happen... how to reproduce that? If I set the token lifetime to 1 minute (hardcoded in ocis and manually rebuild) the token renewal works as expected and I don't get logged out.

@hurradieweltgehtunter
Copy link
Contributor Author

hurradieweltgehtunter commented Aug 16, 2022

Not sure how it happens. I logged in yesterday, let it be, opened the browser tab today and this message appeared.
Maybe it has something to do that this instance gets flushed regularly?

@kulmann
Copy link
Contributor

kulmann commented Aug 16, 2022

Ah ok, then I understand that issue as well. There are two different ways to renew the token: with the (still valid) current access token before it expires or with a refresh token (which typically has a very long lifetime). Default oCIS uses the first way, meaning token renewal only works if the browser is open and you have a working internet connection / connection to the instance. If that's not the case and the token expires then you have nothing you can renew the token with -> the state that you described. Nothing wrong there (only the bug that you described initially), but I will discuss internally if we can hand out refresh tokens by default.

@kulmann kulmann added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels Aug 16, 2022
@AlexAndBear
Copy link
Contributor

Fixed by #7491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants