Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member of project space cannot see public resources link #7406

Closed
ScharfViktor opened this issue Aug 4, 2022 · 8 comments · Fixed by #7424
Closed

Member of project space cannot see public resources link #7406

ScharfViktor opened this issue Aug 4, 2022 · 8 comments · Fixed by #7424
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ownCloud Web UI 5.7.0-rc.7
Infinite Scale 2.0.0-beta.5+8d97b7e1a Community

Steps:

  • admin creates space with folder and file
  • admin creates public link to the folder and to the file
  • admin adds marie as members of the space
  • marie opens folder of the space and trie to find public link

Expected: marie can see public link

Actual: web sends 6 requests to the backend, and some requests contain links, but the user does not see the links on the page

Screenshot 2022-08-04 at 16 45 59

space_ref contains resorseId. Why we need path

@ScharfViktor ScharfViktor added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels Aug 4, 2022
@kulmann
Copy link
Member

kulmann commented Aug 5, 2022

space_ref contains resorseId. Why we need path

We don't (want to) know which backend we're talking to. So we send both path and space_ref. The backend choses what is to be used. oc10 backend will use the path as it doesn't know anything about the space_ref. ocis will use the space_ref and ignores the path.

@kulmann
Copy link
Member

kulmann commented Aug 5, 2022

IMO a backend issue, no? @micbar ?

@micbar
Copy link
Contributor

micbar commented Aug 5, 2022

The indicators are broken in the backend. The ocs api returns the links correctly for the path or space_ref.

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Aug 5, 2022

space_ref contains resorseId. Why we need path

We don't (want to) know which backend we're talking to. So we send both path and space_ref. The backend choses what is to be used. oc10 backend will use the path as it doesn't know anything about the space_ref. ocis will use the space_ref and ignores the path.

Okay, clear.
web works with ocis and one of 6 requests get us link in response. Should we have link on the page?
Screenshot 2022-08-05 at 12 59 59

request https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares?space_ref=1284d238-aa92-42ce-bdc4-0b0000009157%24ff402562-8d09-4268-85de-bee2656f5f5d!f92b7df3-a74d-489c-9f4a-9533f43e3ec3&reshares=true has link in response

@ScharfViktor
Copy link
Contributor Author

The indicators are broken in the backend. The ocs api returns the links correctly for the path or space_ref.

oops, it's not clear to me here. what indicators?

@ScharfViktor
Copy link
Contributor Author

we have public link in response but haven't share. created backend issue: #4347

@kulmann
Copy link
Member

kulmann commented Aug 9, 2022

Looked into the issue. This is a pure frontend issue: we hide the quick link entirely when the logged in user has no share permission. But what we need to do instead is to show the quick link component in readonly mode (only the copy action is allowed, everything else needs to be readonly).

@kulmann
Copy link
Member

kulmann commented Aug 9, 2022

Why we have multiple requests needs investigation as well. Seems odd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants