Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need redirect to files/spaces/projects after disabling or deleting space #7291

Closed
ScharfViktor opened this issue Jul 19, 2022 · 7 comments · Fixed by #7334
Closed

Need redirect to files/spaces/projects after disabling or deleting space #7291

ScharfViktor opened this issue Jul 19, 2022 · 7 comments · Fixed by #7334
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

Web UI 5.7.0-rc.5
ocis: Release 2.0.0-beta.5

Steps:

  • admin creates project space
  • opens the space. On the context menu, click disable and then delete

Expected: the space is deleted. redirect to https://localhost:9200/files/spaces/projects.

Actually: the user is still on the project space page. all buttons are available, after clicking we get an error

Screen.Recording.2022-07-19.at.10.02.53.mov
@ScharfViktor ScharfViktor added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jul 19, 2022
@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jul 26, 2022

Should rather be after disabling space, because some actions are not available on a disabled space, e.G creating a folder

@ScharfViktor
Copy link
Contributor Author

Should rather be after disabling space, because some actions are not available on a disabled space, e.G creating a folder

Probably need redirect after disabling and deleting.
in case:

  • manager disables space
    Expected: redirect to https://localhost:9200/files/spaces/projects
  • manager opens disabled space. Checks something out there
  • manager deletes space
    Expected: redirect to https://localhost:9200/files/spaces/projects

@ScharfViktor ScharfViktor changed the title Need redirect to files/spaces/projects after deleting space Need redirect to files/spaces/projects after disabling or deleting space Jul 26, 2022
@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jul 26, 2022

Afaik it's not possible to open a disabled space, let me check again @ScharfViktor
Edit: Something changed in the backend, prop find on a disabled space returns 404
@micbar desired behaviour?

@phil-davis
Copy link
Contributor

Afaik it's not possible to open a disabled space,...

Yeh, what is the workflow supposed to be after a space is disabled. If I have plenty of privilege, how do I find the disabled spaces, re-enable a disabled space, or completely delete a disabled space.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jul 26, 2022

If I have plenty of privilege, how do I find the disabled spaces, re-enable a disabled space, or completely delete a disabled space.

This is still possible in the spaces overview, but we should prevent entering a disabled space @kulmann agree?

@ScharfViktor
Copy link
Contributor Author

404 Resource not found It's a little confusing for the user.
It would be cool to get 400 with message that you cannot open disabled space

Screen.Recording.2022-07-26.at.14.30.58.mov

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jul 26, 2022

As decided with @tbsbdr

  1. Disabling a space in the particular space view will redirect to the spaces overview
  2. Trying to enter a disabled space will show a warning message and space can not be entered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants