Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use current access token for (re)started uploads #7240

Closed
dschmidt opened this issue Jul 7, 2022 · 1 comment · Fixed by #7296
Closed

Always use current access token for (re)started uploads #7240

dschmidt opened this issue Jul 7, 2022 · 1 comment · Fixed by #7296
Assignees
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working

Comments

@dschmidt
Copy link
Member

dschmidt commented Jul 7, 2022

This is a follow up ticket for #7072.

That PR fixes access token refresh in every currently known/possible scenario, with that it becomes more important to gracefully handle changed access tokens in upload queue handling.
We need to make sure that uploads started (or restarted, e.g., in case of errors) use the new access token and are never started with an outdated token.

@kulmann
Copy link
Member

kulmann commented Jul 7, 2022

To be clear: this was already broken before that PR. While working on that PR it became clear that we need to fix this, but it was clearly out of scope for the PR.

@kulmann kulmann added Type:Bug Something isn't working Priority:p1-urgent Consider a hotfix release with only that fix labels Jul 7, 2022
@JammingBen JammingBen self-assigned this Jul 18, 2022
@kulmann kulmann moved this to Done in Web Support Board Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants