Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Tags in filelist #7169

Closed
5 of 15 tasks
Tracked by #7134
tbsbdr opened this issue Jun 22, 2022 · 4 comments · Fixed by #7388
Closed
5 of 15 tasks
Tracked by #7134

Display Tags in filelist #7169

tbsbdr opened this issue Jun 22, 2022 · 4 comments · Fixed by #7388
Labels
Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 22, 2022

User Story

As a user I want to see if a file is tagged so that I can browse files in a more explorative way.

Value

  • find related files regardless of their location or file name.

Acceptance Criteria

  • New column "Tags" in the filerow
  • Column is only shown, if there are Tags in the current folder--> won't happen as long as we have pagination. value too small
  • Click on a single tag opens the respective SERP SERP: List tagged files #7168
  • If one Tag is too long, it gets truncated ... (bonus: truncation in the middle of the tag)
  • in files table we only display a maximum of 2 tags
  • the number of hidden tags is shown + 4
  • click on + 4 opens the tags sidebar
  • tags are sorted alpha numerically
  • We dispaly a little tag icon beside each individual tag

tags without colors:
image

colored tags (not part of this story)
Tags upfront

Tags upfront

Definition of ready

  • everybody needs to understand the value written in the user story
  • acceptance criteria has to be defined
  • all dependencies of the user story need to be identified
  • feature should be seen from an end user perspective
  • user story has to be estimated
  • story points need to be less then 20

Definition of done

Functional requirements

 functionality described in the user story works

 acceptance criteria are fulfilled

Quality

 codre review happened

 CI is green

 critical code received unit tests by the developer

 automated tests passed (if automated tests are not available, this test needs to be created and passed

Non-functional requirements

 no sonar cloud issues

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jun 29, 2022

@kulmann I think its a good idea to have a predefined, extensible colorpalette in the theme because users might want to chose special colors for their tags in the future. we can then provide the 30 colors defined in the theme (and more if wanted)

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 18, 2022

update: prioritized different colors for tags as 🍰 Cherry on top (nice-to-have). @kulmann

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 18, 2022

@fschade we discussed to bypass the truncation (+4) and drop-menu if there are many tags in the column in the first step:
screenie_Brave Browser_2022-07-18_at_20-33-31@2x

One idea was to just list all tags in the row - but this would result in multi-line row which would mess up the filestable 😕

proposal:

  • truncate tags + show number of truncated tags "+13"
  • click on "+13" opens sidebar with Tags in the file details

could that be a compromise?

image

@kulmann
Copy link
Member

kulmann commented Jul 18, 2022

could that be a compromise?

Yes, please! Could even be the preferred solution (based on user feedback later on). Let's go with this approach. Multi-line rows / rows with variable height are a no go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants