-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing sidebar needs more space or separation #7110
Comments
cc @tbsbdr |
This can also become a problem in different languages? So |
At some point the right sidebar had more space. But maybe it would also help to align the role switcher to the bottom of the row and the three dots button above it 🤔 |
Yeah, that sounds like a good idea! This is what I thought as well. |
Why we have |
|
I see. That is needed then. Thanks for clarification. |
Great stuff! |
Jep, this is because the figma design was setup at 1920x1080 hardware-Pixels whereas Chris' (and many other laptop users resolution) might be ~1440 x 900 CSS-Pixels (equals 75% of 1920 width)
Scale down your browser zoom to 75% and you'll get the figma intended dimensions (which is to small imo) If we tackle the dimension / scaling issue, I would recommend something like 85% compared to the current scale (~ 13-14 px for 1 REM) others: |
as discussed with @janackermann :
|
Steps to reproduce
Expected behaviour
The sharing UI is nice and clean, you can see at a glance where an element ends and a new one begins.
Actual behaviour
The view looks very pressed, the username almost protrudes into the permission schwitcher. Maybe it makes sense to create a visual separation with background contrast? But in any case there should be more space between the second and third element.
Version
ownCloud Web 5.5 RC9
The text was updated successfully, but these errors were encountered: