Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing sidebar needs more space or separation #7110

Closed
ChrisEdS opened this issue Jun 10, 2022 · 15 comments · Fixed by #7252
Closed

Sharing sidebar needs more space or separation #7110

ChrisEdS opened this issue Jun 10, 2022 · 15 comments · Fixed by #7252
Assignees
Labels
Category:Enhancement Add new functionality Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@ChrisEdS
Copy link

ChrisEdS commented Jun 10, 2022

Steps to reproduce

  1. Share a document

Expected behaviour

The sharing UI is nice and clean, you can see at a glance where an element ends and a new one begins.

Actual behaviour

image

The view looks very pressed, the username almost protrudes into the permission schwitcher. Maybe it makes sense to create a visual separation with background contrast? But in any case there should be more space between the second and third element.

Version

ownCloud Web 5.5 RC9

@ChrisEdS ChrisEdS added the Category:Enhancement Add new functionality label Jun 10, 2022
@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jun 10, 2022
@kulmann
Copy link
Member

kulmann commented Jun 10, 2022

cc @tbsbdr

@ChrisEdS
Copy link
Author

This can also become a problem in different languages? So Betrachter can become longer in some cases. Moving this part in a new row might make sense.

@kulmann
Copy link
Member

kulmann commented Jun 10, 2022

At some point the right sidebar had more space. But maybe it would also help to align the role switcher to the bottom of the row and the three dots button above it 🤔

@ChrisEdS
Copy link
Author

Yeah, that sounds like a good idea! This is what I thought as well.

@kulmann
Copy link
Member

kulmann commented Jun 10, 2022

In case of public links we have all configuration options in a line at the bottom and the link itself at the top. Maybe we need to give the sharee name the full row width at the top and put sharee type and options in the line below.

Screenshot 2022-06-10 at 14 31 47

@ChrisEdS
Copy link
Author

ChrisEdS commented Jun 10, 2022

Why we have User or Benutzer under the sharee name? Which other variation or types of users are possible?

@kulmann
Copy link
Member

kulmann commented Jun 10, 2022

Why we have User or Benutzer under the sharee name? Which other variation or types of users are possible?

Group, Guest, Federated are the other share types

@ChrisEdS
Copy link
Author

I see. That is needed then. Thanks for clarification.

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 10, 2022

This is the current state of concept for a worstcase / very crowded scenario:

Figma_2022-06-10_at_15-38-06@2x

imo the ui above could be tidied up a lot if we decide to kill our darling, the 3-Dots and have everything within the dropdown:

Whimsical_2022-06-10_at_15-42-19@2x

--> would you consider killing the 3-Dots an improvement?

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 10, 2022

Proposal:

  • Without 3-Dots
  • Icons more decent (not a11y compliant yet!)
  • removed password-indicators from sharees (don't exist)
  • moved indicators to the left
  • actionable areas where primarily moved to the right
    (still not perfect - draft status..)

--> would you consider killing the 3-Dots an improvement?

Figma_2022-06-10_at_15-57-13@2x

@ChrisEdS
Copy link
Author

Great stuff!

@kulmann
Copy link
Member

kulmann commented Jun 10, 2022

@tbsbdr I don't get it, your mockup has huge amounts of horizontal space, while @ChrisEdS screenshot is a scenario with very little horizontal space.

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 10, 2022

Jep, this is because the figma design was setup at 1920x1080 hardware-Pixels whereas Chris' (and many other laptop users resolution) might be ~1440 x 900 CSS-Pixels (equals 75% of 1920 width)

  • 1440 should also be our target size for standard users (still not scientific-mode)

Scale down your browser zoom to 75% and you'll get the figma intended dimensions (which is to small imo)

If we tackle the dimension / scaling issue, I would recommend something like 85% compared to the current scale (~ 13-14 px for 1 REM)

others:
Onedrive, box and dropbox have 14px for standard text
Google drive has 13 px for standard text.
here in gh standard text is 14 px.

@AlexAndBear
Copy link
Contributor

Current POC:

image

image

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 12, 2022

as discussed with @janackermann :

  • we only show the most important information in the sharee list
  • Move "Type" and "Additional Info" to the backseat (-> "Access details" analogous to the "?"-Context helper)
  • provide Info-i that shows on-click the "Access details"
  • Access details can be extended in the future with more info like "Shared on" or "Shared by".
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants