Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uploaded folders clickable in the upload overlay #7102

Closed
JammingBen opened this issue Jun 8, 2022 · 4 comments · Fixed by #7109
Closed

Make uploaded folders clickable in the upload overlay #7102

JammingBen opened this issue Jun 8, 2022 · 4 comments · Fixed by #7109
Assignees
Labels
Priority:p3-medium Normal priority

Comments

@JammingBen
Copy link
Contributor

When uploading a folder, it would nice to make the folder clickable in the upload overlay.

image

@JammingBen JammingBen added the Priority:p3-medium Normal priority label Jun 8, 2022
@JammingBen JammingBen self-assigned this Jun 8, 2022
@kulmann
Copy link
Contributor

kulmann commented Jun 8, 2022

Similar for files, it would be nice if the uploaded items would trigger the respective default file action on click. I.e. same behaviour as if you'd click on the item in the file list. What do you think?

@JammingBen
Copy link
Contributor Author

Similar for files, it would be nice if the uploaded items would trigger the respective default file action on click. I.e. same behaviour as if you'd click on the item in the file list. What do you think?

I like the idea in general, although this might be a bit more complicated. We'd need to check what's needed for this first, especially if it's necessary to fetch the resource after an upload - which we should avoid at all cost IMO. For me, the overlay is firstly about (read-only-)information, then about navigation, and lastly about actions.

@kulmann
Copy link
Contributor

kulmann commented Jun 8, 2022

Similar for files, it would be nice if the uploaded items would trigger the respective default file action on click. I.e. same behaviour as if you'd click on the item in the file list. What do you think?

I like the idea in general, although this might be a bit more complicated. We'd need to check what's needed for this first, especially if it's necessary to fetch the resource after an upload - which we should avoid at all cost IMO. For me, the overlay is firstly about (read-only-)information, then about navigation, and lastly about actions.

Ack, if it increases network requests then it's a nogo for the moment.

@JammingBen
Copy link
Contributor Author

I tried it, however, file actions do indeed require some data that only comes which a propfind after the upload has finished. That means we only have folder links (at least for now): #7109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants