Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in search results from shares #7043

Closed
aduffeck opened this issue May 23, 2022 · 5 comments · Fixed by #7560
Closed

Broken links in search results from shares #7043

aduffeck opened this issue May 23, 2022 · 5 comments · Fixed by #7560
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@aduffeck
Copy link

With the switch to the share jail the links to the parent directoy in search results from shares became broken.

Steps to reproduce

  1. Create a folder shared containing some file and share it with another user.
  2. As that other user search for the filename of the file in shared

Expected behaviour

The parent directory shows up as shared and clicking it takes me to https://localhost:9200/files/spaces/shares/from-einstein.

Actual behaviour

Search finds the file and previews work, but the link to the parent directory is wrongly named Persönlich and clickin it leads to e.g. https://localhost:9200/files/spaces/personal/home/.

@tbsbdr tbsbdr added Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working labels May 24, 2022
@JammingBen JammingBen self-assigned this Jun 24, 2022
@JammingBen
Copy link
Contributor

Currently on hold as it needs a way to fetch the parent share for files within a share. @fschade is currently building something for this if I'm not mistaken.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jul 28, 2022

@aduffeck I have problems finding a file in a shared folder, REPORT doesn't give me any results

@SwikritiT
Copy link
Contributor

Also, if I click on the file name from the Shares page, it downloads the file, but if I click to personal and click on the file name, it opens the file.

searching.mp4

While in the case of folder clicking on the file name navigates to the personal space.

@AlexAndBear
Copy link
Contributor

@SwikritiT it even goes deeper, if you hit the search all files button and enter a new term, click on a file, nothing will happen (besides console error).

@SwikritiT
Copy link
Contributor

SwikritiT commented Sep 8, 2022

@janackermann I've also created another issue related to searching in the public link don't know if these might be related #7603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants