Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The image space setting is broken. PROPFIND and GET methods give 404 #6874

Closed
ScharfViktor opened this issue May 3, 2022 · 8 comments · Fixed by #6881
Closed

The image space setting is broken. PROPFIND and GET methods give 404 #6874

ScharfViktor opened this issue May 3, 2022 · 8 comments · Fixed by #6881
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ownCloud Web UI 5.5.0
ocis via docker v.1.20

Steps:

  • admin creates space
  • admin opens context menu and click "edit image"
  • admin uploads image jpg:

Actual result:
request1: uploading file -PUT works correctly https://host.docker.internal:9200/remote.php/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157%243e85a541-bb87-4a22-a83f-749886e3b55d/.space/Lake-Constazdxcnce.jpg

request2: setting file as space image - PATCH works correctly https://host.docker.internal:9200/graph/v1.0/drives/1284d238-aa92-42ce-bdc4-0b0000009157%243e85a541-bb87-4a22-a83f-749886e3b55d

request3: getting image image PROPFIND works correctly https://host.docker.internal:9200/remote.php/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157%243e85a541-bb87-4a22-a83f-749886e3b55d/.space/Lake-Constazdxcnce.jpg

Actual result:
request 4- 404 Not found: GEThttps://host.docker.internal:9200/remote.php/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157%243e85a541-bb87-4a22-a83f-749886e3b55d/.space/Lake-Constazdxcnce.jpg?scalingup=0&preview=1&a=1&c=e4e33738f68aab8d755bb5027c108890&x=1200&y=1200

Screenshot 2022-05-03 at 17 40 51

or if you try to upload png image

  • admin uploads image png:
    request 3 PROPFIND https://host.docker.internal:9200/remote.php/dav/spaces/1284d238-aa92-42ce-bdc4-0b0000009157%240d536bf9-b562-4aa2-80a9-08053c80ce04/.space/Screenshot%25202022-05-03%2520at%252009.27.10.png - get 404 error
    <d:error xmlns:d="DAV" xmlns:s="http://sabredav.org/ns"><s:exception>Sabre\DAV\Exception\NotFound</s:exception><s:message>Resource not found</s:message></d:error>

image

@ScharfViktor ScharfViktor added the Type:Bug Something isn't working label May 3, 2022
@ScharfViktor ScharfViktor mentioned this issue May 3, 2022
25 tasks
@C0rby
Copy link
Contributor

C0rby commented May 4, 2022

This has been fixed and works again in ocis master.

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented May 4, 2022

I updated ocis master and the problem went away for files: image.jpg and image.png

but still actual for: name with space.jpg and name with space.png

Screenshot 2022-05-04 at 15 31 53

@C0rby
Copy link
Contributor

C0rby commented May 4, 2022

Yes, you're right. It seems that the file name is double URL encoded. Let me check.

@C0rby
Copy link
Contributor

C0rby commented May 4, 2022

@kulmann, it seems like web encodes the webdav URL again before using it to download the space image.
Last week or so we changed the webdav URL to already come URL encoded so this issue might be fixed by removing the second encoding in web. Could you plan this in the web team?

@kulmann
Copy link
Member

kulmann commented May 4, 2022

@C0rby Is it only for the space image in the graph drives response?

@C0rby
Copy link
Contributor

C0rby commented May 4, 2022

All webdav URLs in the graph response will come URL encoded.

@kulmann
Copy link
Member

kulmann commented May 4, 2022

Ok 👍

@kulmann kulmann transferred this issue from owncloud/ocis May 4, 2022
@kulmann kulmann added the Priority:p2-high Escalation, on top of current planning, release blocker label May 4, 2022
@AlexAndBear
Copy link
Contributor

I tried to figure out why this is happening, the issue seems to be in our owncloud-sdk :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants