Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiver in the public link doesn't work #6423

Closed
ScharfViktor opened this issue Feb 11, 2022 · 9 comments · Fixed by #8466
Closed

Archiver in the public link doesn't work #6423

ScharfViktor opened this issue Feb 11, 2022 · 9 comments · Fixed by #8466
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Feb 11, 2022

web: 4.9.0
ocis: 1.16.0 with docker

Steps:

  • admin creates folder with two files
  • admin creates public link. Role doesn't mater
  • open public link. choose 2 files and click download

Expected result: files downloaded as download.tar. The same behavior if you download folder

Actual result:

Screen.Recording.2022-02-11.at.11.38.59.mov
@ScharfViktor ScharfViktor added Priority:p3-medium Normal priority bug Type:Bug Something isn't working and removed bug labels Feb 11, 2022
@kulmann
Copy link
Member

kulmann commented Feb 11, 2022

Could you add backend logs please? Anything in the ocis logs that looks like an error?

@ScharfViktor
Copy link
Contributor Author

Yes, of course. forgot to do it right away.

{"level":"error","service":"storage","pkg":"rhttp","traceid":"00000000000000000000000000000000","path":"/public/UvLBChmVDJiSCYG","error":"rpc error: code = Unknown desc = error listing shares: rpc error: code = PermissionDenied desc = auth: core access token is invalid","time":"2022-02-11T14:42:58Z","message":"propfindResponse: couldn't list public shares"}

@ScharfViktor ScharfViktor mentioned this issue Feb 11, 2022
25 tasks
@pascalwengerter
Copy link
Contributor

pascalwengerter commented Feb 14, 2022

Can confirm this, 404 error upon calling the archiver

Logs for a single folder download on public link:

{"level":"error","service":"storage","pkg":"rhttp","time":"2022-02-14T11:01:07+01:00","message":"error: not found: storage_id:\"7993447f-687f-490d-875c-ac95e89a62a4\" opaque_id:\"WsvFFxBYHXdJbdF/00ee46e8-81c4-4144-8871-814c2980f372\" "}

Logs for a batch download of multiple items on a public link:

{"level":"error","service":"storage","pkg":"rhttp","time":"2022-02-14T11:02:12+01:00","message":"error: not found: storage_id:\"7993447f-687f-490d-875c-ac95e89a62a4\" opaque_id:\"WsvFFxBYHXdJbdF/0cf4988d-e638-46f5-8778-00a81781eaff\" "}

Interestingly, the archiver download isn't even offered as an option in the UI on password protected links 🤔

@kulmann
Copy link
Member

kulmann commented Feb 14, 2022

Interestingly, the archiver download isn't even offered as an option in the UI on password protected links 🤔

Could you check if the capabilities request was made and successful? If capabilities are not available => archiver is not available because it's announced via capabilities.

@pascalwengerter
Copy link
Contributor

Interestingly, the archiver download isn't even offered as an option in the UI on password protected links 🤔

Could you check if the capabilities request was made and successful? If capabilities are not available => archiver is not available because it's announced via capabilities.

Can't see the capability request in either case and still, I see the download button in non-password-protected links for folders/multiple items

@pascalwengerter
Copy link
Contributor

Interestingly, the archiver download isn't even offered as an option in the UI on password protected links 🤔

Could you check if the capabilities request was made and successful? If capabilities are not available => archiver is not available because it's announced via capabilities.

Can't see the capability request in either case and still, I see the download button in non-password-protected links for folders/multiple items

Also: When using a non-password-protected link, it only loads the capabilities on initial pageload, successive reloads don't fetch them anymore

@elizavetaRa
Copy link
Member

@kulmann Any news on this issue?

@kulmann
Copy link
Member

kulmann commented Jul 19, 2022

The capability loading issues are resolved, but we still disable the archiver for password protected public links here

I checked locally what happens when I allow on the archiver on password protected public links - throws a 401 from the backend. I'll have to investigate what happens there.

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 15, 2023

relates to 889bd00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants