Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiles-view switch #6380

Closed
exalate-issue-sync bot opened this issue Feb 7, 2022 · 5 comments
Closed

tiles-view switch #6380

exalate-issue-sync bot opened this issue Feb 7, 2022 · 5 comments
Labels
Type:Story User Story

Comments

@exalate-issue-sync
Copy link

Description

User Stories

  • As a user I want to switcht between the list and tiles view so that I can have different views on the same folder.

Value

  • improve files navigation & organisation

Acceptance Criteria

  • tiles-view switch Add a switch to toggle between viewmodes: tilesview and list view. (Future: 3rd view: "condesed list" for powerusers like cern)
  • (Note) The viewmode state (list / grid) stays as is, even if the user navigates to another folder (per view).
  • "source of truth" for viewmode is the query parameter (chinese proverb)
  • View mode selection gets written into query parameter

Definition of done

  • Functional requirements
    [ ] functionality described in the user story works
    [ ] acceptance criteria are fulfilled
  • Quality
    [ ] codre review happened
    [ ] CI is green
    [ ] critical code received unit tests by the developer
    [ ] automated tests passed (if automated tests are not available, this test needs to be created and passed
  • Non-functional requirements
    [ ] no sonar cloud issues
@pascalwengerter
Copy link
Contributor

pascalwengerter commented Nov 14, 2022

@kulmann @tbsbdr what's the a11y implications of the condensed view? I have a PoC which overwrites the spacing/font size of the table to allow for more items to be on screen. Is it safe to assume that "since it requires a voluntary interaction by a user" means a less-than-ideal-fontsize is okay? Currently it'd look like this:

Screenshot 2022-11-14 at 22 41 54

@kulmann
Copy link
Member

kulmann commented Nov 15, 2022

Is it safe to assume that "since it requires a voluntary interaction by a user" means a less-than-ideal-fontsize is okay?

that + the way back is very easy (as long as we keep the keyboard focus in the view mode selection, which we should do). But I'm not sure at all about this. 🤷

@pascalwengerter
Copy link
Contributor

Is it safe to assume that "since it requires a voluntary interaction by a user" means a less-than-ideal-fontsize is okay?

that + the way back is very easy (as long as we keep the keyboard focus in the view mode selection, which we should do). But I'm not sure at all about this. 🤷

Let me open a small demo PR later so you+Tobi(+CERN?) can check it out & evaluate?

@pascalwengerter
Copy link
Contributor

@kulmann has been closed via #7991 - I'll open a handful of follow-up feature tickets tomorrow

@JammingBen
Copy link
Contributor

Has been fixed via #7991.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
None yet
Development

No branches or pull requests

3 participants