-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rendering of error in case of no quota space #5937
Comments
@tbsbdr needs concepting (not a lot, but anything to make it actionable 🙏🏽 ) |
proposal:
|
@tbsbdr Having click events on a disabled button is not the best way to go, as some browsers doesn't emit those events: There is still a little bug tough, that's why the tooltip wasn't shown in the first place. |
Tooltip-information should be optional as they are not accessible. I treat them as optional, , meaning: they are nice to have and enhance ux, but the ui must be usable if they were not there. this is at least my understanding, is this correct @kulmann If we can't rely on tooltip information, we would need an accessible solution which would contextual help or notification. |
@tbsbdr If it comes down to a11y, we also have area descriptors on those buttons. |
Well, the linked PR fixes that the tooltips are shown (they were there before but not rendered on disabled buttons). Good first step. For making the information accessible we should just add the information via |
That's not needed. Tooltip for visuals, aria-describedby for screen readers solves the job well. |
When web calls the
/ocs/v1.php/cloud/users/$username
endpoint, it returns back the home quota of the user. If the user doesn't have enough quota, the 'Upload' button is disabled, but no error message is shown. If you inspect the element, you can see the error 'You don't have enough quota to upload' but it's not displayed to the user.The text was updated successfully, but these errors were encountered: