Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not found page #5804

Closed
wkloucek opened this issue Sep 13, 2021 · 10 comments · Fixed by #11737
Closed

Not found page #5804

wkloucek opened this issue Sep 13, 2021 · 10 comments · Fixed by #11737
Assignees

Comments

@wkloucek
Copy link
Contributor

Userstory

As a user I want to have a meaningfull not found page if I opened a non existing URL.

As a user I want to be able to recover from a not found page so that I can navigate to my files again.

Acceptance Criteria

  • A not found page is available
  • The not found page contains a link to ownCloud Web
@wkloucek
Copy link
Contributor Author

@tbsbdr What do you think about this? I have something similar in mind like described here: https://medium.com/designer-recipes/how-to-make-a-custom-404-error-page-for-your-website-1af37a8b20d1

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 13, 2021

Definitely, users should explicitly know if a file was not found. Ideally we can relieve the pain with a sympathetic image or writing.

Also further help/guidance should be provided.

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 14, 2021

Examples how others communicate 404s:
image
image
image
image
image

@kulmann
Copy link
Member

kulmann commented Sep 14, 2021

The screenshots are mixing resource not found within files app and page not found. ;-) A resource not found within files app already exists. See screenshot:

Screenshot 2021-09-14 at 10 12 34

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 14, 2021

@wkloucek Can you work with that or was your request more about a friendlier appearance of the 404?

@wkloucek
Copy link
Contributor Author

@wkloucek Can you work with that or was your request more about a friendlier appearance of the 404?

My request is about a not found site outside of the files app. Eg. when an oC 10 bookmark (eg. https://ocis.ocis-traefik.latest.owncloud.works/apps/files?dir=/&fileid=16) is opened after the migration to oCIS you would just see a "404 not found" page

image

@wkloucek
Copy link
Contributor Author

wkloucek commented Sep 14, 2021

That example could be misleading since one could argue that we are migrating links inside the files app, which is true. But that won't probably apply to other apps, eg. https://ocis.ocis-traefik.latest.owncloud.works/apps/richdocuments/index?fileId=48, so there is always a use case for the 404 site (besides the file not found page in the file app)

@kulmann
Copy link
Member

kulmann commented Sep 14, 2021

I understood from your issue, that it's about a generic 404 page for page not found. I was just pointing out that the screenshots are mixing two different things.

@wkloucek
Copy link
Contributor Author

This is happening when I navigate to a totally wrong route in oC Web 7.0.1:

image

@AlexAndBear AlexAndBear self-assigned this Oct 8, 2024
@AlexAndBear AlexAndBear moved this from Qualification to In progress in Infinite Scale Team Board Oct 8, 2024
@AlexAndBear AlexAndBear moved this from In progress to Done in Infinite Scale Team Board Oct 9, 2024
@kulmann
Copy link
Member

kulmann commented Oct 9, 2024

As we found out today: we can't offer the notFound page in an anonymous context at the moment:

  • user doesn't get initialized
  • apps don't get initialized

We might change that in the future, but for now we need to accept that the notFound page only works in user- and publicLink-contexts. That was now added in #11737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants