Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete pending share option is not available for sharee #5435

Closed
kiranparajuli589 opened this issue Jul 1, 2021 · 1 comment · Fixed by #5374
Closed

delete pending share option is not available for sharee #5435

kiranparajuli589 opened this issue Jul 1, 2021 · 1 comment · Fixed by #5374

Comments

@kiranparajuli589
Copy link
Contributor

Describe the bug

Using with ocis backend with either storage driver, deleting a pending share option for share is not available

Steps to reproduce

Steps to reproduce the behavior:

  1. create two users uu1 and uu2
  2. upload a file lorem.txt using user uu1
  3. share file lorem.txt with user uu2 using user uu1
  4. login with uu2
  5. browse to shared-with-me page
  6. open actions panel for the last share received i.e lorem.txt

Expected behavior

  • delete button to delete the incoming share

Actual behavior

  • delete button pops only after accepting the pending share

Setup

Please describe how you started the server and provide a list of relevant environment variables.

WEB_VERSION=git
BRANCH=master (latest)
OCIS_VERSION=git
BRANCH=master (latest)
STORAGE_FRONTEND_UPLOAD_DISABLE_TUS=false

Additional context

Add any other context about the problem here.

@kulmann
Copy link
Member

kulmann commented Jul 1, 2021

Honestly, on the shared-with-me page I would not expect any Delete button, because I'm looking at shares. I would expect Accept share and Decline share buttons only. This PR #5374 modifies the behaviour so that the shared with me page only shows a Decline share button in the right sidebar, not a Delete button anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants