Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 9.3.3.1 - Error detection #5396

Closed
tbsbdr opened this issue Jun 25, 2021 · 6 comments
Closed

[a11y] 9.3.3.1 - Error detection #5396

tbsbdr opened this issue Jun 25, 2021 · 6 comments
Assignees

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 25, 2021


Status: partly fulfilled

  • Page 1 (Alle Dateien)
    When creating a public link and in case the user leaves the fields empty, an error message appears above the form:
    a) The error message is in English language but should be in German - "error creating public share"
    b) The text of the error message is not informative because it doesn’t explain what went wrong (what data caused the error?)
    c) The error message is not handled by screenreaders. One solution could be the use of aria- live or role="alert“.

Status: fulfilled

  • Page 2 (Mit anderen geteilten Dateien)

Status: not applicable

  • Page 3 (Gelöschte Dateien)
  • Page 4 (Konto)
@lookacat
Copy link
Contributor

  1. The workflow as described doesn't lead to an error.
    to a) in the filesharing sidebar all messages are translated using $gettext
    to b) as discribed in 1. the error doesn't exist, other possible errors in the component are meaningful
    to c) role=alert will be set

@kulmann
Copy link
Member

kulmann commented Jul 23, 2021

Error message is coming untranslated from the server.

@kulmann
Copy link
Member

kulmann commented Aug 24, 2021

OcAlert has role="alert" now since owncloud/owncloud-design-system@895c090

@kulmann
Copy link
Member

kulmann commented Aug 24, 2021

We fixed the frontend side form validation for required password. Other fields don't have any requirements. Only thing left are unforeseen server side errors. For those we now show a generic error message as a notification (read by screenreaders, disappears after a few seconds). 14a12b8

@kulmann
Copy link
Member

kulmann commented Aug 24, 2021

Also made sure that the same is fine for people shares and that focus management doesn't break.
49c9f03

@pascalwengerter
Copy link
Contributor

Closing here since backend errors now get wrapped in a user-friendly and translated way

Screenshot 2024-06-24 at 14 18 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants