Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 9.2.4.1 - Skip areas #5391

Closed
4 tasks done
tbsbdr opened this issue Jun 25, 2021 · 4 comments · Fixed by #10802
Closed
4 tasks done

[a11y] 9.2.4.1 - Skip areas #5391

tbsbdr opened this issue Jun 25, 2021 · 4 comments · Fixed by #10802

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 25, 2021


General notes

Status: rather fulfilled

  • Page 2 (Mit anderen geteilten Dateien)
    See general notes.

  • Page 3 (Gelöschte Dateien)
    See general notes.

  • Page 4 (Konto)
    The content area of the site is not marked up with a main landmark.

Status: partly fulfilled

  • Page 1 (Alle Dateien)
    Copy or move elements: the breadcrumb navigation was correctly implemented with a nav element but it has no label. For labelling an aria-label attribute could be used. See general notes.
@pascalwengerter
Copy link
Contributor

Needs a fix in the ODS

@stevefrenzel
Copy link

stevefrenzel commented Nov 8, 2021

@tbsbdr @kulmann @pascalwengerter

I would suggest replacing the header element of the sidebar with a figure element. The header element on the individual pages makes more sense than in the sidebar, unless this leads to not meeting an accessibility requirement.

Alternatively a div with a role of "img". In it's core it's a link, but first and foremost an image, so this would solve the issue. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/img_role

@pascalwengerter
Copy link
Contributor

As pointed out in #6007 it may be we have to add dedicated <main> tags for the pages in the runtime - the runtime otherwise relies on the rendered app to provide a <main> tag since it doesn't take any guesses on how the rendered app is structured. Not sure if this is necessary for the A11y audit though

@pascalwengerter
Copy link
Contributor

As pointed out in #6007 it may be we have to add dedicated <main> tags for the pages in the runtime - the runtime otherwise relies on the rendered app to provide a <main> tag since it doesn't take any guesses on how the rendered app is structured. Not sure if this is necessary for the A11y audit though

Not sure what I was going for here, feel free to ignore. Just merged a PR in ODS (owncloud/owncloud-design-system#1773) that should resolve what is pointed out in general notes, thanks to @stevefrenzel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants