Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate requests when homeFolder is enabled #4860

Closed
ishank011 opened this issue Mar 25, 2021 · 2 comments · Fixed by #4918
Closed

Duplicate requests when homeFolder is enabled #4860

ishank011 opened this issue Mar 25, 2021 · 2 comments · Fixed by #4918

Comments

@ishank011
Copy link

For a homeFolder value of /eos/user/{{substr 0 1 .Id}}/{{.Id}}, we see repeated requests when visiting the web app for the first time

/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos%2Fuser%2Fi&reshares=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos%2Fuser%2Fi&shared_with_me=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos%2Fuser%2Fi&reshares=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos%2Fuser&reshares=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos%2Fuser%2Fi&shared_with_me=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos%2Fuser&shared_with_me=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos%2Fuser&reshares=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos%2Fuser&shared_with_me=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos&reshares=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos&shared_with_me=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos&reshares=true
/ocs/v1.php/apps/files_sharing/api/v1/shares?path=%2Feos&shared_with_me=true

While we shouldn't be sending the same requests again and again, I don't understand why we need to send these for the parent directories in the first place.

@labkode
Copy link

labkode commented Apr 6, 2021

@kulmann any news on this? Performance is impacted by such number of requests

@kulmann
Copy link
Member

kulmann commented Apr 6, 2021

The bug was unrelated to the homeFolder feature.

Context: we're loading the shares of the current folder and all parent folders to be able to display share indicators on the listed resources (because it might be shared via a parent folder). This is cached for the current path. If you leave the current path (i.e. go to a child of the path or to a sibling) the cache gets cleared. If you traverse to parents, shares are already cached.

Fix is here: #4918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants