[QA] blank page with trivial syntax errors in config.json

[jnweiger]

Seen with web-1.0.2

Follow the instructions at https://github.com/owncloud/QA/blob/master/Server/Test_Plan_web.md

but introduce a trivial syntax error in config.json -- e.g. a trailing comma , before closing } brace:

      "title": { "en": "Classic Design", "de": "Dateien", },

• the oauth2 authorization is performed,
• then the browser is redirected to a blank web page.
• server has no error messages, neither in the docker logs output, nor in owncloud.log with log verbosity "Everything".
• firefox console reports (only)
  

Expected behaviour: The json syntax error is reported. Somewhere.

[micbar]

Not so easy. The same happens when you add a comment in the json file.

@kulmann @LukasHirt We could add config.json validation, but please be sure that this doesn't happen on every request.

[LukasHirt]

but please be sure that this doesn't happen on every request.

We fetch the config once when Web is opened:

web/src/web.js

Line 214 in 5878eeb

config = await fetch('config.json')

So it should be already safe to do the validation and not be afraid of having it in every request. The config is then afterwards saved to store.

[LukasHirt]

Something to consider https://www.npmjs.com/package/jsonschema

[individual-it]

ToDo QA-Team:

• add unit tests for this case

[LukasHirt]

add UI tests for this case

@individual-it Would it be possible to get this done with unit tests?

[individual-it]

good thought, I haven't looked into what they currently doing but I've changed the todo above