-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info about number of selected items and their size #3850
Conversation
The interaction to clear selection doesn't look different at all currently. Is taken care of in owncloud/owncloud-design-system#418 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some visual things I noticed:
Clear selection
raw button has a height of 22px, while the text left of it has a height of 17px. Because of this, theClear selection
text overflows to the bottom, which looks off.- The pipe
|
between text and clear selection button is quite short. I would expect it to have the same height as all the other text. - When you shrink the windows size so that the left sidebar disappears, the info about selected items and the
clear selection
button disappear entirely. Might be intended, but this way shrinking the windows causes the ui to lose information and one quite handy action (clearing the selection). selected
suffix from the action buttons still needs to be removed ;-)
This is on purpose until we figure out the app bar layout on smaller screens. Adding there more elements makes it almost unusable already. #3774
It was already removed in the previous commit. Just forgot to remove it now from tests - will do next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I've aligned it with flexbox.
With the flexbox in place, it should be now aligned as well. But since it's using font size it's possible that some screens might slightly differ. Here's a screenshot with the new alignment: |
a51554b
to
06828e2
Compare
a3d4b61
to
43c9787
Compare
We've added information about the number of selected items and their size above the files list next to batch actions
43c9787
to
32aa100
Compare
Description
We've added information about the number of selected items and their size above the files list next to batch actions.
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes