Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient localizations .... #3766

Closed
DeepDiver1975 opened this issue Jul 13, 2020 · 0 comments · Fixed by #3769
Closed

Insufficient localizations .... #3766

DeepDiver1975 opened this issue Jul 13, 2020 · 0 comments · Fixed by #3769
Assignees

Comments

@DeepDiver1975
Copy link
Member

  1. Take care about gender of injected works - e.g. ''Are you sure you want to delete this %{type}?' type is file or folder. Both have different gender in some languages and 'this' requires different gender as well.
    solution: talk about 'resources' in general of use two strings
    https://github.com/owncloud/phoenix/blob/20a3b0bf4dac3ba4bf8588564b03337aede59464/apps/files/src/mixins/deleteResources.js#L59
  • Permanently delete %{type} %{name}
  • Are you sure you want to delete this %{type}?
  • Select %{type} %{name}
  • You don't have permission to share this %{type}
  • search for %{type} in the code base ;-)
  1. always use proper plural translations - missing e.g. in 'Permanently delete %{amount} selected resources?' refs https://github.com/owncloud/phoenix/blob/20a3b0bf4dac3ba4bf8588564b03337aede59464/apps/files/src/mixins/deleteResources.js#L27
  • %{count} resources could not be copied
  • %{count} resources could not be moved
  • %{numberOfFiles} items will be deleted immediately. You can’t undo this action.
  • %{numberOfFiles} items will be deleted immediately. You can’t undo this action.
  • Are you sure you want delete %{numberOfFiles} selected items?
  • Delete %{amount} selected resources
  • search fro %{amount} %{count} %{numberOfFiles}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant