Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled expiration date are handled differently in links and collaborator share #3168

Closed
kiranparajuli589 opened this issue Mar 10, 2020 · 2 comments

Comments

@kiranparajuli589
Copy link
Contributor

Description

After #3086, expiration feature is on both links and collaborators share, but one thing to be noticed:
When using past dates or using enforced expiration dates, there are dates which cannot be set as new expiration date

Inside collaborators share(core/phoenix):
Such dates [year, month, day] are disabled and can't be selected. (without any err msgs or popups)
Screenshot from 2020-03-10 16-46-50

Inside links share(phoenix):
Such dates can be selected but after selection, a error message is displayed as
Screenshot from 2020-03-10 16-42-22

Inside links share(core):
Such dates are disabled and can't be selected. (without any err msgs or popups)
Screenshot from 2020-03-10 16-49-09

Steps to reproduce

  1. Use enforced expiration date for collaborators/links shares
  2. Try to set past-dates or dated beyond maximum expiration date

Expected behaviour

Similar handling mechanism

Actual behaviour

Different techniques used in link shares and collaboration share in phoenix

Server configuration

latest core master
latest phoenix master

@PVince81
Copy link
Contributor

@pmaier1 @LukasHirt

@pascalwengerter
Copy link
Contributor

Seems like this has been long fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants