Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register store which is imported instead of required #2837

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Register store which is imported instead of required #2837

merged 1 commit into from
Jan 13, 2020

Conversation

LukasHirt
Copy link
Collaborator

Description

Register a store module even if it was imported into extension instead of required.

Motivation and Context

Don't enforce how the store is included in the extension.

How Has This Been Tested?

  • test environment: Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Jan 10, 2020
@LukasHirt LukasHirt self-assigned this Jan 10, 2020
@LukasHirt LukasHirt changed the title Register store which is not imported as a module Register store which is imported instead of required Jan 10, 2020
@LukasHirt LukasHirt force-pushed the bugfix/load-store-which-are-not-module branch from 4e7808e to 519d179 Compare January 10, 2020 10:30
PVince81
PVince81 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit ea86fcf into master Jan 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/load-store-which-are-not-module branch January 13, 2020 08:54
@LukasHirt LukasHirt mentioned this pull request Jan 13, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @PVince81