-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display previews #276
Comments
I wonder if this are really hard requirements for the frontend. Cons:
|
Previews would start to become interesting once we get to implement a grid view of files (like gallery). Indeed the previews are rather small and even for pictures it doesn't show much. |
The previews will be retrieved using the Webdav API like OC 10 has. |
=> would require pre-signed URLs on OC 10 side So far the current logic is ok for images but would require the pre-signed URL approach for videos. |
@C0rby ^ |
to clarify, we already have an implementation that uses the preview endpoint in the media viewer app, and the approach above is what I described, see:
|
similar topic happens for downloads: #526 (comment) for the scope of this sprint I suggest focusing only on bringing the same logic to the file list and its thumbnail retrieval. later on we can look into pre-signed URL as part of https://github.com/owncloud/enterprise/issues/3912 |
updated top post with some findings |
server side merged with owncloud/ocis#157 |
PR for file previews in file list was merged: #3187 next up is adding a preview on top of the sidebar and solving the further points |
We're now able to display thumbnails and do so for certain file types in the files list/table. There's also discussions about having larger previews in the sidebar or on a grid view, but that's a different story. If further previews are needed please open a new ticket. |
Note: the last entries in expected-failures linked to this issue are removed in PR #5787 |
The text was updated successfully, but these errors were encountered: