Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bitmask in bitmaskToRole function #2516

Closed
LukasHirt opened this issue Nov 21, 2019 · 1 comment
Closed

Use bitmask in bitmaskToRole function #2516

LukasHirt opened this issue Nov 21, 2019 · 1 comment
Labels
Topic:good-first-issue beginner friendly task
Milestone
backlog

Comments

@LukasHirt
Copy link
Collaborator

At this moment, bitmaskToRole will work only in the case that the role has only one additional permission. To allow more additional permissions and to have the function safer, we need to use bitmask inside.
@LukasHirt LukasHirt added this to the backlog milestone Nov 21, 2019
@LukasHirt LukasHirt mentioned this issue Nov 21, 2019
Merged
9 tasks
@kulmann kulmann added the Topic:good-first-issue beginner friendly task label Mar 18, 2021
@kulmann
Copy link
Member

kulmann commented May 9, 2022

This has been refactored into proper (typescript) classes => done
https://github.com/owncloud/web/blob/master/packages/web-app-files/src/helpers/share/role.ts

@kulmann kulmann closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Topic:good-first-issue beginner friendly task
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
2 participants
@kulmann @LukasHirt