Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex theming #2404

Closed
PVince81 opened this issue Nov 7, 2019 · 6 comments
Closed

Complex theming #2404

PVince81 opened this issue Nov 7, 2019 · 6 comments
Assignees
Labels
Estimation:XXL(13) Priority:p2-high Escalation, on top of current planning, release blocker

Comments

@PVince81
Copy link
Contributor

PVince81 commented Nov 7, 2019

Requirements

  • Exchange assets (icons, buttons, ...)
  • Size of HTML elements (logo,
  • Margins, paddings, sizes (e.g., height of top bar)
  • Consent on login => needs separate extension, not theming
  • Ability to change arbitrary strings and translations (ex: User types in sharing (e.g. "Guest" => "EXTERNAL"; GC))
@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Nov 7, 2019
@PVince81
Copy link
Contributor Author

PVince81 commented Nov 7, 2019

  • have a look at existing Phoenix internal theme to find out which bits we needed to adjust (texts, etc) and define extension points to allow such extensions

@PVince81 PVince81 added the Priority:p2-high Escalation, on top of current planning, release blocker label Nov 11, 2019
@PVince81
Copy link
Contributor Author

4d for the diff

@PVince81
Copy link
Contributor Author

we should work on the diff first in case we find more items to discuss for complex theming

@PVince81
Copy link
Contributor Author

Possible extension of requirements:

Idea: split this ticket further into:

  • complex theming that is about replacing stuff visually (string, margin, icons)
  • customizing which is about writing extensions and modifying visual behavior ?

@PVince81
Copy link
Contributor Author

  • important to discuss: with complex theming, how to provide alignment on mobile and desktop clients, considering the broad scope of customizations ?

@kulmann kulmann removed this from the Milestone 1: Phoenix for users milestone Oct 27, 2022
@pascalwengerter pascalwengerter self-assigned this Nov 7, 2023
@pascalwengerter
Copy link
Contributor

I guess this can been closed/has been addressed via #9698? I'd prefer smaller and more actionable tickets going forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimation:XXL(13) Priority:p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

No branches or pull requests

4 participants