if no share were send/received "shared with you/others" must not show all files

[individual-it]

Steps to reproduce

1. have a user that did not receive or send ever a share
2. navigate to "All Files"
3. navigate to "Shared with me"
4. navigate to "shared with others"

Expected behaviour

"shared with me" & "shared with others" should be empty

Actual behaviour

all files of the user are listed

[PVince81]

From what I see, the logic is skipping "LOAD_FILES" action whenever there are no results from the OCS Share call for both views.

It should be modified to actually clear the current file list.

[PVince81]

Ok, it seems to use the first entry in the list for currentFolder as our current state expects a value for it. So it's not trivial to generate an empty result set there without virtualizing the currentFolder.

I don't think the current code is correct. We need to be able to support a flat list of results that do not have any current folder in place, like the list of favorites or shares. The view should be able to work with a null currentFolder then.

I'll need to talk with @LukasHirt about a proper solution.

[PVince81]

as discussed with @LukasHirt, the first attempt will be at removing the requirement that currentFolder is set. might require going through the whole source code...

[PVince81]

slightly related to #2077 in terms of reusable file list

[PVince81]

• remove requirement for currentFolder in file lists
• add "flat list" mode which it based on whether currentFolder is set or not, then allow duplicate file names to fix Not possible to rename a file on the favorites page to a name of a file from an other folder #1750

[LukasHirt]

The base issue is solved in #2280 thanks to the reset of the files array when the folder is being loaded. Still, needs anyway all the mentioned fixes.

[PVince81]

this isn't happening any more. I extensively tested such scenario when testing the "empty indicator" for the lists, closing.