Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files list needs to be sortable #1854

Closed
LukasHirt opened this issue Aug 28, 2019 · 7 comments · Fixed by #3078
Closed

Files list needs to be sortable #1854

LukasHirt opened this issue Aug 28, 2019 · 7 comments · Fixed by #3078
Assignees
Labels

Comments

@LukasHirt
Copy link
Collaborator

Description

User needs to be allowed to sort the files list. Either having clickable header rows which would sort it or have somewhere a sort by drop (maybe better since on mobile view we hide almost every header row)

@LukasHirt LukasHirt added Category:Enhancement Add new functionality Priority:p3-medium Normal priority labels Aug 28, 2019
@LukasHirt LukasHirt added this to the backlog milestone Aug 28, 2019
@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2019

In the current design I was expecting to find it under the filter icon on the top right.

@PVince81
Copy link
Contributor

even if we don't provide an option yet, at least I think we should properly sort it to have the folders on top, instead of this:
image

@PVince81
Copy link
Contributor

This is the client side JS sorters from the old UI: https://github.com/owncloud/core/blob/master/apps/files/js/filelist.js#L3065

@PVince81
Copy link
Contributor

PVince81 commented Sep 13, 2019

Draft (broken) PR for default sort: #1972

@LukasHirt
Copy link
Collaborator Author

I think it would be nice to have as well some advanced sort options in the future e. g. "Shared items first" or "Favourite items first".

@PVince81
Copy link
Contributor

Nice idea.

We need to be careful to not overwhelm the user with too many options. We should think about the common use cases and provide a few sorting options for that.

Last time I asked you where to put the sort options and we agreed on using a dropdown instead of clickable columns. This aligns with the idea of providing sort options that do not match specific columns.

@PVince81 PVince81 modified the milestones: backlog, Milestone 1: Phoenix for users Sep 24, 2019
@PVince81 PVince81 self-assigned this Feb 21, 2020
@PVince81
Copy link
Contributor

PR here: #3078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants