Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving GeoGebra Notes Integration Issue: Camera Access in iFrames #12121

Open
dj4oC opened this issue Jan 22, 2025 · 5 comments · Fixed by #12188
Open

Resolving GeoGebra Notes Integration Issue: Camera Access in iFrames #12121

dj4oC opened this issue Jan 22, 2025 · 5 comments · Fixed by #12188
Assignees

Comments

@dj4oC
Copy link

dj4oC commented Jan 22, 2025

Background:

We are integrating GeoGebra Notes as an external app into ownCloud Infinite Scale. During testing, it was identified that the camera functionality does not work as expected. The issue stems from the missing allow="camera" attribute in the <iframe> where GeoGebra Notes is loaded.

Technical Context:

The relevant code can be found here:
App.vue Line 2-8

To enable camera functionality in GeoGebra Notes, we need to modify the allow attribute of the <iframe> tag to include camera. This change ensures that the browser grants the required permission to GeoGebra Notes for accessing the camera.

Action Plan:

  1. Update Code:
    Add allow="camera" to the iframe in the App.vue file of the web-app-external package.
<iframe
  :src="app.url"
  :sandbox="app.sandbox"
  allow="camera"
  frameborder="0"
  class="web-app-external"
></iframe>
  1. Testing:
  • Verify that the camera functionality works as intended in GeoGebra Notes after applying the change.
  • Test the impact of adding the camera attribute on security and compliance policies.
  • Ensure other iframe functionalities are not adversely affected.
@kobergj kobergj removed their assignment Jan 22, 2025
@kobergj kobergj moved this from Qualification to Prio 3 or less in Infinite Scale Team Board Jan 22, 2025
@dj4oC dj4oC changed the title iFrame allow=camera Resolving GeoGebra Notes Integration Issue: Camera Access in iFrames Jan 22, 2025
@dj4oC dj4oC moved this from Prio 3 or less to Prio 2 in Infinite Scale Team Board Jan 22, 2025
@kobergj
Copy link
Contributor

kobergj commented Jan 22, 2025

Thank you chatGPT! Maybe it would be even better to use a parameter instead of allowing camera everywhere. But that depends on how much work that would be.

@kobergj kobergj moved this from Prio 2 to Backlog in Infinite Scale Team Board Feb 5, 2025
@LukasHirt LukasHirt self-assigned this Feb 14, 2025
@LukasHirt LukasHirt moved this from Backlog to In progress in Infinite Scale Team Board Feb 14, 2025
@LukasHirt
Copy link
Collaborator

LukasHirt commented Feb 18, 2025

@kobergj to make this configurable, it would make most sense to have it configurable in oCIS and then Web would only read and use the config accordingly. Reason for that: the external apps are loaded via API call into oCIS, not a Web config. So it would be simply about keeping the information together. And e.g. secure_view config already lives there.

However, since that would increase the effort, should we do that or simply go with "allow always" solution?

@kobergj
Copy link
Contributor

kobergj commented Feb 18, 2025

Yes let's go with the simple solution for now. Probably no one will ever complain about it 👍

@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Feb 19, 2025
@dj4oC dj4oC moved this from Done to Qualification in Infinite Scale Team Board Mar 5, 2025
@dj4oC
Copy link
Author

dj4oC commented Mar 5, 2025

Reopened. Unfortunately it still does not work. Same behaviour as before. Happy to make a screen sharing session.
@kobergj @LukasHirt

@LukasHirt LukasHirt reopened this Mar 5, 2025
@github-project-automation github-project-automation bot moved this from Qualification to In progress in Infinite Scale Team Board Mar 5, 2025
@LukasHirt LukasHirt moved this from In progress to Prio 1 in Infinite Scale Team Board Mar 5, 2025
@LukasHirt
Copy link
Collaborator

@dj4oC I would need to see whether there is any error output in the browser console.

@LukasHirt LukasHirt moved this from Prio 1 to In progress in Infinite Scale Team Board Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants