File with a space is replaced with + on downloading

[ScharfViktor]

Version 6.1.0
Web client version 9.1.0
MacOs 14.4.1

Steps:

• create file new file.odt (with space)
• download file

Expected: file is downloaded as new file.odt

Actual: file is downloaded as new+file.odt

[JammingBen]

Might be a fallout from cs3org/reva#4748 😬

Edit: fix here: cs3org/reva#4762

[ScharfViktor]

@JammingBen please adapt the e2e download.feature when you fix this bug as https://github.com/owncloud/web/compare/downloadFileWithSpace?expand=1

We could have found this degradation if we had a test for it, but we didn't.

[ScharfViktor]

file with ? : * | \ ; <>-> changed as _

[JammingBen]

file with ? : * | \ ; <>-> changed as _

This "issue" is not new though, and I'm not sure if there is anything we can do about it. The content-disposition header is being encoded correctly, so this seems to be a browser thing. @kulmann How do you feel about this, acceptable?

[kulmann]

file with ? : * | \ ; <>-> changed as _

This "issue" is not new though, and I'm not sure if there is anything we can do about it. The content-disposition header is being encoded correctly, so this seems to be a browser thing. @kulmann How do you feel about this, acceptable?

That's acceptable. As long as blanks work correctly again. 👍

[JammingBen]

Fixed via the current oCIS rolling release.

See #11187 for the e2e test adjustment.