Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allow-same-origin from iframe sandbox attribute #10716

Open
DeepDiver1975 opened this issue Apr 5, 2024 · 1 comment
Open

Remove allow-same-origin from iframe sandbox attribute #10716

DeepDiver1975 opened this issue Apr 5, 2024 · 1 comment
Assignees
@DeepDiver1975
Labels
Type:Bug Something isn't working

Comments

@DeepDiver1975
Copy link
Member

allow-same-origin allows the iframed app to access the parent DOM.

This is sub-optimal from a security perspective and shall be removed.

In order to allow interaction between iframe and parent postMessage() shall be used.

Affected extensions:

  • draw-io
  • app-external (OnlyOffice and Collabora)
@DeepDiver1975 DeepDiver1975 added the Type:Bug Something isn't working label Apr 5, 2024
@DeepDiver1975 DeepDiver1975 self-assigned this Apr 5, 2024
@DeepDiver1975
Copy link
Member Author

jgraph/drawio#4340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeepDiver1975 DeepDiver1975

Labels
Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DeepDiver1975 @pascalwengerter