Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App bootstrap fails if system is set to dark and there is no dark theme #10657

Closed
kulmann opened this issue Mar 21, 2024 · 1 comment
Closed
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Mar 21, 2024

Describe the bug

Given an ownCloud instance with only a light theme fails in app bootstrap if the operating system is set to dark mode.
(also happens the other way around, only a dark theme but system is set to light mode)

Steps to reproduce

  1. Set up an ownCloud which only has a light theme
  2. Set your operating system to dark mode
  3. Visit your ownCloud instance in a private browser tab

Expected behavior

The ownCloud page you tried to open loads like it should, rendered with the only available theme.

Actual behavior

Missing or invalid config page is shown

Additional context

Happens on stable-8.0 (I didn't test if it also happens on master).
This is the line where it fails:

currentThemeName.value = unref(availableThemes).find((t) => t.isDark === unref(isDark)).name

@kulmann kulmann added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker labels Mar 21, 2024
@kulmann kulmann moved this from Qualification to Prio 2 in Infinite Scale Team Board Mar 21, 2024
@JammingBen JammingBen self-assigned this Mar 21, 2024
@JammingBen
Copy link
Contributor

Fixed via #10659.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants