Limit the number of concurrent share invite requests

[kulmann]

Describe the bug

Apparently ocis has issues with concurrent share creations on the same file. To mitigate this quickly, we want to set a (configurable) limit for the number of share receivers in one invite concurrent requests.

Steps to reproduce

1. Create a file
2. Add 20 share receivers
3. click the submit button

Expected behavior

Short request/response duration and no failing invites.

Actual behavior

Slow consecutive requests, sometimes failing, if the deployment/instance is slow in general.

Solution

We want to set a configurable number of concurrent requests here

web/packages/web-app-files/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue

Line 479 in fa19d32

const saveQueue = new PQueue({ concurrency: 4 })

Would like to propose the config.json structure as follows:

options: {
  concurrentRequests: {
    default: number,
    invites: number,
    uploads: number
  }
}

Affected versions

Needs to be fixed in stable-7.1 AND stable-8.0 so that we can provide a fix for ocis-4.0 and the upcoming ocis-5.0.

[JammingBen]

Fixed via #10230. Now needs to target the other branches as well.

[kulmann]

Brought the config to ocis master via owncloud/ocis#8056 - also needs to be backported to ocis stable-4.0.

[AlexAndBear]

This is still open, any actions we should take from here because p1?

[kulmann]

Depends. Backport to stable-7.1 would still be needed to close this issue if (and only if) the bycs team can handle further patches of the ocis-4.0 minor version. We didn't receive a definitive answer or it didn't reach me.

@dragotin could you shed some light on this? For ocis-5.0 the work is done. I'd like to close here because this is not a bug in the general product.

[micbar]

We can close here IMHO