From bd9531abb969cb2083c0d08b18ca09bcb57bd64c Mon Sep 17 00:00:00 2001 From: JG <133214016+grimmoc@users.noreply.github.com> Date: Thu, 28 Sep 2023 09:54:52 +0200 Subject: [PATCH] self-built app banner (#9696) * wip self-built app banner * wip almost complete * complete, final tests pending * fixed URL generation, works! * clean up * added changelog * fixed pnpm lock * linting * fixed test * changes per request in pr * added tests, moved component to web pkg * minor cosmetic changes * changes per request from PO * added custom translation hack * fixed after rebase * removed console log --- changelog/unreleased/enhancement-app-banner | 5 + packages/web-app-files/package.json | 2 +- .../src/views/spaces/DriveResolver.vue | 6 +- .../unit/views/spaces/DriveResolver.spec.ts | 2 +- packages/web-app-preview/src/App.vue | 5 + packages/web-pkg/src/components/AppBanner.vue | 153 ++++++++++++++++++ .../web-pkg/src/components/QuotaSelect.vue | 2 +- .../web-pkg/src/helpers/router/buildUrl.ts | 33 ++++ packages/web-pkg/src/helpers/router/index.ts | 1 + .../tests/unit/components/AppBanner.spec.ts | 96 +++++++++++ packages/web-runtime/src/App.vue | 1 + .../src/helpers/additionalTranslations.ts | 3 +- packages/web-runtime/src/router/helpers.ts | 32 ---- .../src/services/auth/userManager.ts | 9 +- .../src/services/clientRegistration.ts | 5 +- .../tests/unit/router/index.spec.ts | 16 +- .../owncloud/assets/owncloud-app-icon.png | Bin 0 -> 39591 bytes .../web-runtime/themes/owncloud/theme.json | 16 ++ 18 files changed, 342 insertions(+), 45 deletions(-) create mode 100644 changelog/unreleased/enhancement-app-banner create mode 100644 packages/web-pkg/src/components/AppBanner.vue create mode 100644 packages/web-pkg/src/helpers/router/buildUrl.ts create mode 100644 packages/web-pkg/tests/unit/components/AppBanner.spec.ts create mode 100644 packages/web-runtime/themes/owncloud/assets/owncloud-app-icon.png diff --git a/changelog/unreleased/enhancement-app-banner b/changelog/unreleased/enhancement-app-banner new file mode 100644 index 00000000000..49315cbc60a --- /dev/null +++ b/changelog/unreleased/enhancement-app-banner @@ -0,0 +1,5 @@ +Enhancement: Added app banner for mobile devices + +We've added an app banner at the top of the web view for mobile devices asking the user whether they want to continue working in the app. By dismissing it, it will not show again until a new session is started, e.g. by opening a new tab. + +https://github.com/owncloud/web/pull/9696 diff --git a/packages/web-app-files/package.json b/packages/web-app-files/package.json index fa7d63a340f..ed1999e1a9d 100644 --- a/packages/web-app-files/package.json +++ b/packages/web-app-files/package.json @@ -27,8 +27,8 @@ "sanitize-html": "^2.7.0", "uuid": "^9.0.0", "vue-concurrency": "4.0.1", - "vue3-gettext": "^2.3.3", "vue-router": "4.2.0", + "vue3-gettext": "^2.3.3", "vuex": "4.1.0", "web-app-files": "workspace:*", "web-app-search": "workspace:*", diff --git a/packages/web-app-files/src/views/spaces/DriveResolver.vue b/packages/web-app-files/src/views/spaces/DriveResolver.vue index cd021574bd8..3e5b19a1ce2 100644 --- a/packages/web-app-files/src/views/spaces/DriveResolver.vue +++ b/packages/web-app-files/src/views/spaces/DriveResolver.vue @@ -1,6 +1,7 @@