From a68ab6128f25fe817cfc4e93c4f0c287457142bb Mon Sep 17 00:00:00 2001 From: Dominik Schmidt Date: Mon, 23 Jan 2023 09:39:26 +0100 Subject: [PATCH] [full-ci] TypeScript almost everything (#8289) * Rename .js files to .ts This renames most of the actively used .js files to .ts. Notable exceptions: acceptance tests, docs, a few legacy (config) files for design system or web-app-skeleton * Fix imports * Fix global variables usage * fixup! Fix imports * Fix exports * Fix non-isolated modules * Fix types in clientRegistration * Fix breadcrumbs unit test * Fix jest config * Fix remaining type issues * Fix textUtils.naturalSortCompare --- .../src/components/OcAvatars/OcAvatars.vue | 2 +- .../src/composables/{index.js => index.ts} | 0 .../{index.spec.js => index.spec.ts} | 2 +- .../useIsVisible/{index.js => index.ts} | 0 packages/design-system/src/index.ts | 4 +- .../src/mixins/{sort.js => sort.ts} | 0 .../src/utils/{logger.js => logger.ts} | 0 .../src/utils/{shareType.js => shareType.ts} | 0 .../utils/{sizeClasses.js => sizeClasses.ts} | 0 .../{uniqueId.spec.js => uniqueId.spec.ts} | 0 .../src/utils/{uniqueId.js => uniqueId.ts} | 2 +- .../{webFontLoader.js => webFontLoader.ts} | 0 .../src/{index.js => index.ts} | 4 +- .../src/{index.js => index.ts} | 2 +- .../src/{index.js => index.ts} | 2 +- packages/web-app-files/src/fileSideBars.ts | 6 +-- ...textualHelpers.js => contextualHelpers.ts} | 0 .../src/helpers/{path.js => path.ts} | 0 .../{permissions.js => permissions.ts} | 0 .../helpers/{textUtils.js => textUtils.ts} | 2 +- .../web-app-files/src/{index.js => index.ts} | 0 ...eBreadcrumb.js => accessibleBreadcrumb.ts} | 0 .../{clearSelection.js => clearSelection.ts} | 0 .../src/mixins/actions/{copy.js => copy.ts} | 0 .../mixins/actions/{delete.js => delete.ts} | 0 ...{downloadArchive.js => downloadArchive.ts} | 4 +- .../{downloadFile.js => downloadFile.ts} | 0 .../{emptyTrashBin.js => emptyTrashBin.ts} | 0 .../actions/{favorite.js => favorite.ts} | 0 .../src/mixins/actions/{move.js => move.ts} | 0 .../src/mixins/actions/{paste.js => paste.ts} | 0 .../{showActions.js => showActions.ts} | 0 .../{showEditTags.js => showEditTags.ts} | 0 .../{uploadImage.js => uploadImage.ts} | 3 +- packages/web-app-files/src/router/router.ts | 25 +++++----- .../{fileActions.js => fileActions.ts} | 8 ++- .../{mimeTypes.js => mimeTypes.ts} | 0 .../SideBar/Actions/FileActions.spec.ts | 2 +- ...readcrumbs.spec.js => breadcrumbs.spec.ts} | 19 ++++--- .../helpers/{path.spec.js => path.spec.ts} | 0 ...ermissions.spec.js => permissions.spec.ts} | 2 +- ...icator.spec.js => statusIndicator.spec.ts} | 2 + .../tests/unit/helpers/textUtils.spec.js | 34 ------------- .../tests/unit/helpers/textUtils.spec.ts | 49 +++++++++++++++++++ .../mixins/actions/clearSelection.spec.ts | 2 +- .../tests/unit/mixins/actions/delete.spec.ts | 2 +- .../unit/mixins/actions/emptyTrashBin.spec.ts | 2 +- .../unit/mixins/spaces/uploadImage.spec.ts | 2 +- .../src/{index.js => index.ts} | 2 +- .../src/{index.js => index.ts} | 5 +- .../src/{index.js => index.ts} | 11 +++-- .../components/sideBar/{index.js => index.ts} | 0 .../web-pkg/src/components/sideBar/types.ts | 8 +-- .../src/defaults/{json.js => json.ts} | 0 .../src/defaults/{vue.js => vue.ts} | 2 - .../src/helpers/{config.js => config.ts} | 0 packages/web-runtime/src/index.ts | 10 +--- .../mixins/{focusMixin.js => focusMixin.ts} | 0 .../{lifecycleMixin.js => lifecycleMixin.ts} | 0 ...{navigationMixin.js => navigationMixin.ts} | 2 +- .../src/plugins/{web.js => web.ts} | 2 +- ...tRegistration.js => clientRegistration.ts} | 2 +- .../web-runtime/src/store/{app.js => app.ts} | 0 .../src/store/{apps.js => apps.ts} | 0 .../src/store/{config.js => config.ts} | 0 .../src/store/{modal.js => modal.ts} | 2 +- .../store/{navigation.js => navigation.ts} | 0 .../src/store/{settings.js => settings.ts} | 0 .../{config.spec.js => config.spec.ts} | 11 +++-- .../helpers/{theme.spec.js => theme.spec.ts} | 18 +++---- tests/unit/config/jest.config.ts | 4 +- .../config/{jest.init.js => jest.init.ts} | 6 +-- .../{jest.overrides.js => jest.overrides.ts} | 2 + web.d.ts | 5 +- 74 files changed, 148 insertions(+), 126 deletions(-) rename packages/design-system/src/composables/{index.js => index.ts} (100%) rename packages/design-system/src/composables/useIsVisible/{index.spec.js => index.spec.ts} (97%) rename packages/design-system/src/composables/useIsVisible/{index.js => index.ts} (100%) rename packages/design-system/src/mixins/{sort.js => sort.ts} (100%) rename packages/design-system/src/utils/{logger.js => logger.ts} (100%) rename packages/design-system/src/utils/{shareType.js => shareType.ts} (100%) rename packages/design-system/src/utils/{sizeClasses.js => sizeClasses.ts} (100%) rename packages/design-system/src/utils/{uniqueId.spec.js => uniqueId.spec.ts} (100%) rename packages/design-system/src/utils/{uniqueId.js => uniqueId.ts} (62%) rename packages/design-system/src/utils/{webFontLoader.js => webFontLoader.ts} (100%) rename packages/web-app-admin-settings/src/{index.js => index.ts} (93%) rename packages/web-app-draw-io/src/{index.js => index.ts} (92%) rename packages/web-app-external/src/{index.js => index.ts} (89%) rename packages/web-app-files/src/helpers/{contextualHelpers.js => contextualHelpers.ts} (100%) rename packages/web-app-files/src/helpers/{path.js => path.ts} (100%) rename packages/web-app-files/src/helpers/{permissions.js => permissions.ts} (100%) rename packages/web-app-files/src/helpers/{textUtils.js => textUtils.ts} (98%) rename packages/web-app-files/src/{index.js => index.ts} (100%) rename packages/web-app-files/src/mixins/{accessibleBreadcrumb.js => accessibleBreadcrumb.ts} (100%) rename packages/web-app-files/src/mixins/actions/{clearSelection.js => clearSelection.ts} (100%) rename packages/web-app-files/src/mixins/actions/{copy.js => copy.ts} (100%) rename packages/web-app-files/src/mixins/actions/{delete.js => delete.ts} (100%) rename packages/web-app-files/src/mixins/actions/{downloadArchive.js => downloadArchive.ts} (95%) rename packages/web-app-files/src/mixins/actions/{downloadFile.js => downloadFile.ts} (100%) rename packages/web-app-files/src/mixins/actions/{emptyTrashBin.js => emptyTrashBin.ts} (100%) rename packages/web-app-files/src/mixins/actions/{favorite.js => favorite.ts} (100%) rename packages/web-app-files/src/mixins/actions/{move.js => move.ts} (100%) rename packages/web-app-files/src/mixins/actions/{paste.js => paste.ts} (100%) rename packages/web-app-files/src/mixins/actions/{showActions.js => showActions.ts} (100%) rename packages/web-app-files/src/mixins/actions/{showEditTags.js => showEditTags.ts} (100%) rename packages/web-app-files/src/mixins/spaces/actions/{uploadImage.js => uploadImage.ts} (97%) rename packages/web-app-files/tests/__fixtures__/{fileActions.js => fileActions.ts} (96%) rename packages/web-app-files/tests/__fixtures__/{mimeTypes.js => mimeTypes.ts} (100%) rename packages/web-app-files/tests/unit/helpers/{breadcrumbs.spec.js => breadcrumbs.spec.ts} (58%) rename packages/web-app-files/tests/unit/helpers/{path.spec.js => path.spec.ts} (100%) rename packages/web-app-files/tests/unit/helpers/{permissions.spec.js => permissions.spec.ts} (99%) rename packages/web-app-files/tests/unit/helpers/{statusIndicator.spec.js => statusIndicator.spec.ts} (97%) delete mode 100644 packages/web-app-files/tests/unit/helpers/textUtils.spec.js create mode 100644 packages/web-app-files/tests/unit/helpers/textUtils.spec.ts rename packages/web-app-pdf-viewer/src/{index.js => index.ts} (92%) rename packages/web-app-preview/src/{index.js => index.ts} (81%) rename packages/web-app-text-editor/src/{index.js => index.ts} (88%) rename packages/web-pkg/src/components/sideBar/{index.js => index.ts} (100%) rename packages/web-runtime/src/defaults/{json.js => json.ts} (100%) rename packages/web-runtime/src/defaults/{vue.js => vue.ts} (91%) rename packages/web-runtime/src/helpers/{config.js => config.ts} (100%) rename packages/web-runtime/src/mixins/{focusMixin.js => focusMixin.ts} (100%) rename packages/web-runtime/src/mixins/{lifecycleMixin.js => lifecycleMixin.ts} (100%) rename packages/web-runtime/src/mixins/{navigationMixin.js => navigationMixin.ts} (98%) rename packages/web-runtime/src/plugins/{web.js => web.ts} (97%) rename packages/web-runtime/src/services/{clientRegistration.js => clientRegistration.ts} (94%) rename packages/web-runtime/src/store/{app.js => app.ts} (100%) rename packages/web-runtime/src/store/{apps.js => apps.ts} (100%) rename packages/web-runtime/src/store/{config.js => config.ts} (100%) rename packages/web-runtime/src/store/{modal.js => modal.ts} (98%) rename packages/web-runtime/src/store/{navigation.js => navigation.ts} (100%) rename packages/web-runtime/src/store/{settings.js => settings.ts} (100%) rename packages/web-runtime/tests/unit/helpers/{config.spec.js => config.spec.ts} (87%) rename packages/web-runtime/tests/unit/helpers/{theme.spec.js => theme.spec.ts} (82%) rename tests/unit/config/{jest.init.js => jest.init.ts} (90%) rename tests/unit/config/{jest.overrides.js => jest.overrides.ts} (98%) diff --git a/packages/design-system/src/components/OcAvatars/OcAvatars.vue b/packages/design-system/src/components/OcAvatars/OcAvatars.vue index 8dffa62a8db..2d76221817b 100644 --- a/packages/design-system/src/components/OcAvatars/OcAvatars.vue +++ b/packages/design-system/src/components/OcAvatars/OcAvatars.vue @@ -30,7 +30,7 @@