diff --git a/tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature b/tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature index 78b0df5d98a..4c7b8fd97d9 100644 --- a/tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature +++ b/tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature @@ -595,7 +595,7 @@ Feature: Sharing files and folders with internal users | shareWith | user2 | | expireDate | 2038-10-12 | And user "user1" has logged in using the webUI - When user "user1" edits share with user "User Two" of file "lorem.txt" changing following + When the user edits share with user "User Two" of file "lorem.txt" changing following | expireDate | +7 | Then user "user2" should have received a share with target "lorem (2).txt" and expiration date in 7 days And user "user1" should have a share with these details: diff --git a/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js b/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js index 32370726ef1..a5ba6ae5282 100644 --- a/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js +++ b/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js @@ -487,12 +487,12 @@ module.exports = { return this.useXpath().expect.element(collaboratorSelector).to.not.be.present }, /** - * @param sharer * @param collaborator * @param value + * * @return {Promise<*>} */ - changeCollaboratorExpiryDate: async function (sharer, collaborator, value) { + changeCollaboratorExpiryDate: async function (collaborator, value) { await collaboratorDialog.clickEditShare(collaborator) await this.api.page .FilesPageElement diff --git a/tests/acceptance/stepDefinitions/sharingContext.js b/tests/acceptance/stepDefinitions/sharingContext.js index 1a24bcd9ab5..170a09423a5 100644 --- a/tests/acceptance/stepDefinitions/sharingContext.js +++ b/tests/acceptance/stepDefinitions/sharingContext.js @@ -132,13 +132,8 @@ const shareFileFolder = function ( * create any share using dataTable * * @param {string} sharer - * @param {object} dataTable - * @param {string} dataTable.path - * @param {string} dataTable.shareWith - * @param {string} dataTable.expireDate - * @param {string} dataTable.name - * @param {string} dataTable.permissionString - * @param {string} dataTable.password + * @param {object} dataTable (attrs like: path, shareWith, expireDate, name, permissionString, + * password can be passed inside dataTable) * * @return void */ @@ -777,15 +772,15 @@ When( } ) -When('user {string} edits share with user {string} of file/folder/resource {string} changing following', - async function (sharer, collaborator, resource, dataTable) { +When('the user edits share with user {string} of file/folder/resource {string} changing following', + async function (collaborator, resource, dataTable) { const api = client.page.FilesPageElement const settings = dataTable.rowsHash() await api .appSideBar() .closeSidebar(100) .openSharingDialog(resource) - return api.sharingDialog().changeCollaboratorExpiryDate(sharer, collaborator, settings.expireDate) + return api.sharingDialog().changeCollaboratorExpiryDate(collaborator, settings.expireDate) }) Then('user {string} should be listed as {string} in the collaborators list on the webUI', function (user, role) {