From 8ad955a5d805f87bc5f3838cbfe1c742ac445885 Mon Sep 17 00:00:00 2001
From: Pascal Wengerter <pascal@wengerter.info>
Date: Tue, 7 Nov 2023 19:59:48 +0100
Subject: [PATCH] Add themeSwitcher for more >2 themes as OcDrop, further
 streamline theming logic

---
 .../src/composables/piniaStores/theme.ts      | 28 +++++--
 .../src/components/Topbar/ThemeSwitcher.vue   | 76 ++++++++++---------
 .../src/components/Topbar/TopBar.vue          |  1 -
 .../web-runtime/src/container/bootstrap.ts    |  8 +-
 4 files changed, 68 insertions(+), 45 deletions(-)

diff --git a/packages/web-pkg/src/composables/piniaStores/theme.ts b/packages/web-pkg/src/composables/piniaStores/theme.ts
index dc6eb8446a8..fb4810a5037 100644
--- a/packages/web-pkg/src/composables/piniaStores/theme.ts
+++ b/packages/web-pkg/src/composables/piniaStores/theme.ts
@@ -49,8 +49,8 @@ export const useThemeStore = defineStore('theme', () => {
   const hasOnlyTwoThemesForLightDarkMode = computed(
     () =>
       availableThemes.value.length === 2 &&
-      availableThemes.value.some((x) => x.isDark === true) &&
-      availableThemes.value.some((x) => x.isDark !== true)
+      availableThemes.value.some((t) => t.isDark === true) &&
+      availableThemes.value.some((t) => t.isDark !== true)
   )
 
   const initializeThemes = (themes: WebTheme[], newCommonTheme: CommonTheme) => {
@@ -58,18 +58,31 @@ export const useThemeStore = defineStore('theme', () => {
     commonTheme.value = newCommonTheme
 
     const currentThemeName = useLocalStorage('oc_currentThemeName', null) // note: use null as default so that we can fall back to system preferences
-    // Set default fallback theme names
+    // Set default theme name as fallback
     if (unref(currentThemeName) === null) {
-      currentThemeName.value = usePreferredDark().value ? themeNameDark : themeNameLight
+      const isDark = usePreferredDark()
+      currentThemeName.value = isDark.value ? themeNameDark : themeNameLight
     }
 
     // TODO: Fix this by passing full theme?
     // TODO: Discuss handling (former) default scenario
-    setCurrentTheme(availableThemes.value.find((x) => x.general.name === currentThemeName.value))
+    setAndApplyTheme(availableThemes.value.find((t) => t.general.name === currentThemeName.value))
   }
 
-  const setCurrentTheme = (theme: WebTheme) => {
+  const setAndApplyTheme = (theme: WebTheme) => {
     currentTheme.value = theme
+
+    for (const param in currentTheme.value.designTokens.colorPalette) {
+      ;(document.querySelector(':root') as HTMLElement).style.setProperty(
+        `--oc-color-${param}`,
+        theme.designTokens.colorPalette[param]
+      )
+    }
+  }
+
+  // This should only be used with hasOnlyTwoThemesForLightDarkMode - we know there's exactly two themes, one with darkMode and one without
+  const toggleTheme = () => {
+    setAndApplyTheme(availableThemes.value.find((t) => t.isDark !== currentTheme.value.isDark))
   }
 
   return {
@@ -78,6 +91,7 @@ export const useThemeStore = defineStore('theme', () => {
     hasOnlyOneTheme,
     hasOnlyTwoThemesForLightDarkMode,
     initializeThemes,
-    setCurrentTheme
+    setAndApplyTheme,
+    toggleTheme
   }
 })
diff --git a/packages/web-runtime/src/components/Topbar/ThemeSwitcher.vue b/packages/web-runtime/src/components/Topbar/ThemeSwitcher.vue
index 33b2835a89a..27376be2a94 100644
--- a/packages/web-runtime/src/components/Topbar/ThemeSwitcher.vue
+++ b/packages/web-runtime/src/components/Topbar/ThemeSwitcher.vue
@@ -1,6 +1,6 @@
 <template>
-  <!-- TODO: Only show if themes.length === 2 && 1 theme isDark === true && 1 theme isDark === false -->
   <oc-button
+    v-if="hasOnlyTwoThemesForLightDarkMode"
     v-oc-tooltip="buttonLabel"
     class="themeswitcher-btn"
     :aria-label="buttonLabel"
@@ -11,55 +11,63 @@
     <span class="oc-visible@s" :aria-label="switchLabel" />
     <oc-icon :name="switchIcon" fill-type="line" variation="inherit" />
   </oc-button>
-  <!-- TODO: Add button + ocdrop for >2 themes or (themes.length === 2 && both isDark || !isDark) -->
+  <template v-else-if="availableThemes.length > 2">
+    <oc-button
+      id="files-view-options-btn"
+      key="files-view-options-btn"
+      v-oc-tooltip="buttonLabel"
+      data-testid="files-view-options-btn"
+      :aria-label="buttonLabel"
+      appearance="raw"
+      class="oc-my-s oc-p-xs"
+    >
+      <oc-icon name="settings-3" fill-type="line" />
+    </oc-button>
+    <oc-drop
+      drop-id="files-view-options-drop"
+      toggle="#files-view-options-btn"
+      mode="click"
+      class="oc-width-auto"
+      padding-size="medium"
+    >
+      <oc-list>
+        <li
+          v-for="theme in availableThemes"
+          :key="theme.general.name"
+          class="files-view-options-list-item"
+        >
+          <oc-button @click="setAndApplyTheme(theme)">{{ theme.general.name }}</oc-button>
+        </li>
+      </oc-list>
+    </oc-drop>
+  </template>
 </template>
 <script lang="ts">
-import { computed, unref, watch, defineComponent, ref } from 'vue'
+import { computed, defineComponent } from 'vue'
 import { useGettext } from 'vue3-gettext'
-import { useStore, useLocalStorage } from '@ownclouders/web-pkg'
-import { themeNameDark, themeNameLight, useDefaultThemeName } from '../../composables'
-
-// TODO: Consider using https://vueuse.org/core/useColorMode/#usecolormode
+import { useThemeStore } from '@ownclouders/web-pkg'
+import { storeToRefs } from 'pinia'
 
 export default defineComponent({
   setup() {
     const { $gettext } = useGettext()
-    const store = useStore()
+    const themeStore = useThemeStore()
 
-    const currentThemeName = ref('')
+    const { setAndApplyTheme, toggleTheme } = themeStore
 
-    // TODO: Move to theme store?
-    currentThemeName.value = useLocalStorage('oc_currentThemeName', useDefaultThemeName())
-    const currentTheme = computed(() => store.getters.configuration.themes[unref(currentThemeName)])
-    const applyTheme = (theme) => {
-      for (const param in theme.designTokens.colorPalette) {
-        ;(document.querySelector(':root') as HTMLElement).style.setProperty(
-          `--oc-color-${param}`,
-          theme.designTokens.colorPalette[param]
-        )
-      }
-    }
+    const { availableThemes, currentTheme, hasOnlyTwoThemesForLightDarkMode } =
+      storeToRefs(themeStore)
 
     const buttonLabel = computed(() => $gettext('Click to switch theme'))
     const switchLabel = computed(() => $gettext('Currently used theme'))
-
-    watch(currentThemeName, async () => {
-      await store.dispatch('loadTheme', { theme: unref(currentTheme) })
-      applyTheme(unref(currentTheme))
-    })
-
-    const isLightTheme = computed(() => [null, themeNameLight].includes(currentThemeName.value))
-
-    const switchIcon = computed(() => (isLightTheme.value ? 'sun' : 'moon-clear'))
-
-    const toggleTheme = () => {
-      currentThemeName.value = isLightTheme.value ? themeNameDark : themeNameLight
-    }
+    const switchIcon = computed(() => (currentTheme.value.isDark === false ? 'sun' : 'moon-clear'))
 
     return {
+      availableThemes,
       buttonLabel,
-      currentThemeName,
       currentTheme,
+      hasOnlyTwoThemesForLightDarkMode,
+      setAndApplyTheme,
       switchIcon,
       switchLabel,
       toggleTheme
diff --git a/packages/web-runtime/src/components/Topbar/TopBar.vue b/packages/web-runtime/src/components/Topbar/TopBar.vue
index f22e3e47143..9d7ed481c22 100644
--- a/packages/web-runtime/src/components/Topbar/TopBar.vue
+++ b/packages/web-runtime/src/components/Topbar/TopBar.vue
@@ -301,4 +301,3 @@ export default {
   }
 }
 </style>
-@ownclouders/web-pkg/src/composables/piniaStores/theme
diff --git a/packages/web-runtime/src/container/bootstrap.ts b/packages/web-runtime/src/container/bootstrap.ts
index 55d90bdfa8f..4bf3edfe6db 100644
--- a/packages/web-runtime/src/container/bootstrap.ts
+++ b/packages/web-runtime/src/container/bootstrap.ts
@@ -30,6 +30,7 @@ import { merge } from 'lodash-es'
 import { AppConfigObject } from '@ownclouders/web-pkg'
 import { MESSAGE_TYPE } from '@ownclouders/web-client/src/sse'
 import { getQueryParam } from '../helpers/url'
+import { storeToRefs } from 'pinia'
 
 /**
  * fetch runtime configuration, this step is optional, all later steps can use a static
@@ -283,15 +284,16 @@ export const announceTheme = async ({
   designSystem: any
   runtimeConfiguration?: RuntimeConfiguration
 }): Promise<void> => {
-  // TODO: StoreToRefs, or nah?
-  const { currentTheme, initializeThemes } = useThemeStore()
+  const themeStore = useThemeStore()
+  const { initializeThemes } = themeStore
+  const { currentTheme } = storeToRefs(themeStore)
 
   const { web, common } = await loadTheme(runtimeConfiguration?.theme)
 
   await initializeThemes([web], common)
 
   app.use(designSystem, {
-    tokens: currentTheme.designTokens
+    tokens: currentTheme.value.designTokens
   })
 }