From 433207e4a938ac1c459c6e905e049b4029a5066c Mon Sep 17 00:00:00 2001 From: Pascal Wengerter Date: Tue, 29 Nov 2022 00:32:23 +0100 Subject: [PATCH] Fix-8008: Don't open sharing sidebar after creating/copying quicklink --- .../enhancement-no-sidebar-when-copying-quicklink | 6 ++++++ .../web-app-files/src/mixins/actions/createQuicklink.ts | 4 ---- packages/web-app-files/src/quickActions.js | 2 -- 3 files changed, 6 insertions(+), 6 deletions(-) create mode 100644 changelog/unreleased/enhancement-no-sidebar-when-copying-quicklink diff --git a/changelog/unreleased/enhancement-no-sidebar-when-copying-quicklink b/changelog/unreleased/enhancement-no-sidebar-when-copying-quicklink new file mode 100644 index 00000000000..3a624355635 --- /dev/null +++ b/changelog/unreleased/enhancement-no-sidebar-when-copying-quicklink @@ -0,0 +1,6 @@ +Enhancement: Don't open sidebar when copying quicklink + +Following user feedback, we don't open the sharing sidebar anymore after copying/creating a quicklink. + +https://github.com/owncloud/web/issues/8008 +https://github.com/owncloud/web/pull/8036 diff --git a/packages/web-app-files/src/mixins/actions/createQuicklink.ts b/packages/web-app-files/src/mixins/actions/createQuicklink.ts index 48d797f5493..33960054dd9 100644 --- a/packages/web-app-files/src/mixins/actions/createQuicklink.ts +++ b/packages/web-app-files/src/mixins/actions/createQuicklink.ts @@ -3,8 +3,6 @@ import { createQuicklink } from '../../helpers/share' import { ShareStatus } from 'web-client/src/helpers/share' import { isLocationSharesActive } from '../../router' -import { eventBus } from 'web-pkg/src/services/eventBus' -import { SideBarEventTopics } from '../../composables/sideBar' export default { computed: { @@ -43,8 +41,6 @@ export default { store, $gettext: this.$gettext }) - - eventBus.publish(SideBarEventTopics.openWithPanel, 'sharing-item#linkShares') } } } diff --git a/packages/web-app-files/src/quickActions.js b/packages/web-app-files/src/quickActions.js index ee84a4cb7d8..da41351ac16 100644 --- a/packages/web-app-files/src/quickActions.js +++ b/packages/web-app-files/src/quickActions.js @@ -67,12 +67,10 @@ export default { if (passwordEnforced) { return showQuickLinkPasswordModal(ctx, async (password) => { await createQuicklink({ ...ctx, resource: ctx.item, password }) - eventBus.publish(SideBarEventTopics.openWithPanel, 'sharing-item#linkShares') }) } await createQuicklink({ ...ctx, resource: ctx.item }) - eventBus.publish(SideBarEventTopics.openWithPanel, 'sharing-item#linkShares') }, displayed: canShare }