From 4aad05a2a961a5ff55630b39fc559bfba8356fbf Mon Sep 17 00:00:00 2001
From: Jan <j.ackermann91@gmail.com>
Date: Thu, 8 Sep 2022 18:10:33 +0200
Subject: [PATCH] Compare Save Dialog, simplify

---
 .../components/Groups/SideBar/EditPanel.vue   | 16 ++++++-------
 .../components/Users/SideBar/EditPanel.vue    | 24 ++++++++-----------
 .../Users/SideBar/GroupAssignmentsPanel.vue   | 22 +++++++----------
 3 files changed, 27 insertions(+), 35 deletions(-)

diff --git a/packages/web-app-user-management/src/components/Groups/SideBar/EditPanel.vue b/packages/web-app-user-management/src/components/Groups/SideBar/EditPanel.vue
index 25203d85f44..9405dc161e5 100644
--- a/packages/web-app-user-management/src/components/Groups/SideBar/EditPanel.vue
+++ b/packages/web-app-user-management/src/components/Groups/SideBar/EditPanel.vue
@@ -13,15 +13,15 @@
         :fix-message-line="true"
         @input="validateDisplayName"
       />
+      <compare-save-dialog
+        class="edit-compare-save-dialog oc-mb-l"
+        :original-object="group"
+        :compare-object="editGroup"
+        :confirm-button-disabled="invalidFormData"
+        @revert="revertChanges"
+        @confirm="$emit('confirm', editGroup)"
+      ></compare-save-dialog>
     </div>
-    <compare-save-dialog
-      class="edit-compare-save-dialog oc-pb-l oc-pt-s oc-px-m"
-      :original-object="group"
-      :compare-object="editGroup"
-      :confirm-button-disabled="invalidFormData"
-      @revert="revertChanges"
-      @confirm="$emit('confirm', editGroup)"
-    ></compare-save-dialog>
   </div>
 </template>
 <script>
diff --git a/packages/web-app-user-management/src/components/Users/SideBar/EditPanel.vue b/packages/web-app-user-management/src/components/Users/SideBar/EditPanel.vue
index 9b5dd95e411..dd1c88da66d 100644
--- a/packages/web-app-user-management/src/components/Users/SideBar/EditPanel.vue
+++ b/packages/web-app-user-management/src/components/Users/SideBar/EditPanel.vue
@@ -40,6 +40,7 @@
         </div>
         <quota-select
           v-if="showQuota"
+          class="oc-mb-s"
           :key="'quota-select-' + user.id"
           :title="$gettext('Personal quota')"
           :total-quota="editUser.drive.quota.total || 0"
@@ -49,15 +50,15 @@
           To set an individual quota, the user needs to have logged in once.
         </p>
       </div>
+      <compare-save-dialog
+        class="edit-compare-save-dialog oc-mb-l"
+        :original-object="user"
+        :compare-object="editUser"
+        :confirm-button-disabled="invalidFormData"
+        @revert="revertChanges"
+        @confirm="$emit('confirm', editUser)"
+      ></compare-save-dialog>
     </div>
-    <compare-save-dialog
-      class="edit-compare-save-dialog oc-pb-l oc-pt-s oc-px-m"
-      :original-object="user"
-      :compare-object="editUser"
-      :confirm-button-disabled="invalidFormData"
-      @revert="revertChanges"
-      @confirm="$emit('confirm', editUser)"
-    ></compare-save-dialog>
   </div>
 </template>
 <script>
@@ -160,12 +161,7 @@ export default {
 <style lang="scss">
 #user-edit-panel {
   #user-edit-form {
-    border-top-left-radius: 5px;
-    border-top-right-radius: 5px;
-  }
-  .edit-compare-save-dialog {
-    border-bottom-left-radius: 5px;
-    border-bottom-right-radius: 5px;
+    border-radius: 5px;
   }
 }
 </style>
diff --git a/packages/web-app-user-management/src/components/Users/SideBar/GroupAssignmentsPanel.vue b/packages/web-app-user-management/src/components/Users/SideBar/GroupAssignmentsPanel.vue
index 0ed663c5889..7279f2f2d3a 100644
--- a/packages/web-app-user-management/src/components/Users/SideBar/GroupAssignmentsPanel.vue
+++ b/packages/web-app-user-management/src/components/Users/SideBar/GroupAssignmentsPanel.vue
@@ -3,6 +3,7 @@
     <UserInfoBox :user="user" />
     <div id="user-group-assignment-form" class="oc-background-highlight oc-p-m">
       <oc-select
+        class="oc-mb-s"
         v-model="editUser.memberOf"
         multiple
         :options="groups"
@@ -35,14 +36,14 @@
           </div>
         </template>
       </oc-select>
+      <compare-save-dialog
+        class="edit-compare-save-dialog oc-mb-l"
+        :original-object="user"
+        :compare-object="editUser"
+        @revert="revertChanges"
+        @confirm="$emit('confirm', editUser)"
+      ></compare-save-dialog>
     </div>
-    <compare-save-dialog
-      class="edit-compare-save-dialog oc-pb-l oc-pt-s oc-px-m"
-      :original-object="user"
-      :compare-object="editUser"
-      @revert="revertChanges"
-      @confirm="$emit('confirm', editUser)"
-    ></compare-save-dialog>
   </div>
 </template>
 <script>
@@ -90,12 +91,7 @@ export default {
 <style lang="scss">
 #user-group-assignment-panel {
   #user-group-assignment-form {
-    border-top-left-radius: 5px;
-    border-top-right-radius: 5px;
-  }
-  .edit-compare-save-dialog {
-    border-bottom-left-radius: 5px;
-    border-bottom-right-radius: 5px;
+    border-radius: 5px;
   }
 }
 </style>