diff --git a/changelog/unreleased/enhancement-extensions-sidebar-panels b/changelog/unreleased/enhancement-extensions-sidebar-panels index 853fdb325b2..a521abf3e25 100644 --- a/changelog/unreleased/enhancement-extensions-sidebar-panels +++ b/changelog/unreleased/enhancement-extensions-sidebar-panels @@ -5,3 +5,4 @@ The benefit of this is that any app can register additional panels to be shown i available panels were hardcoded. https://github.com/owncloud/web/pull/10111 +https://github.com/owncloud/web/pull/10152 diff --git a/changelog/unreleased/enhancement-file-sidebar b/changelog/unreleased/enhancement-file-sidebar index 463d14ac89f..d0a8d68ca03 100644 --- a/changelog/unreleased/enhancement-file-sidebar +++ b/changelog/unreleased/enhancement-file-sidebar @@ -4,3 +4,4 @@ Viewer and editor apps now have the same right sidebar available like the `files This makes in place viewing file details, tagging, sharing, and much more possible. https://github.com/owncloud/web/pull/10111 +https://github.com/owncloud/web/pull/10152 diff --git a/packages/web-app-external/src/App.vue b/packages/web-app-external/src/App.vue index 6ee08f2938f..16457192ef8 100644 --- a/packages/web-app-external/src/App.vue +++ b/packages/web-app-external/src/App.vue @@ -6,7 +6,7 @@ :title="iFrameTitle" allowfullscreen /> -
+
diff --git a/packages/web-app-external/tests/unit/__snapshots__/app.spec.ts.snap b/packages/web-app-external/tests/unit/__snapshots__/app.spec.ts.snap index 618f8cc38ca..0fa9db98cd7 100644 --- a/packages/web-app-external/tests/unit/__snapshots__/app.spec.ts.snap +++ b/packages/web-app-external/tests/unit/__snapshots__/app.spec.ts.snap @@ -9,7 +9,7 @@ exports[`The app provider extension should be able to load an iFrame via get 1`] exports[`The app provider extension should be able to load an iFrame via post 1`] = ` -
+
diff --git a/packages/web-app-files/src/components/FilesList/ResourceDetails.vue b/packages/web-app-files/src/components/FilesList/ResourceDetails.vue index eb51a4c1021..67f74f52bb6 100644 --- a/packages/web-app-files/src/components/FilesList/ResourceDetails.vue +++ b/packages/web-app-files/src/components/FilesList/ResourceDetails.vue @@ -14,8 +14,7 @@ import { Resource, SpaceResource } from '@ownclouders/web-client/src/helpers' import FileActions from '../SideBar/Actions/FileActions.vue' import FileDetails from '../SideBar/Details/FileDetails.vue' -import FileInfo from '../SideBar/FileInfo.vue' -import { useFileActions } from '@ownclouders/web-pkg' +import { useFileActions, FileInfo } from '@ownclouders/web-pkg' import { useRouteQuery } from '@ownclouders/web-pkg' export default defineComponent({ diff --git a/packages/web-app-files/src/components/SideBar/FileInfo.vue b/packages/web-app-files/src/components/SideBar/FileInfo.vue deleted file mode 100644 index 25a58e4120c..00000000000 --- a/packages/web-app-files/src/components/SideBar/FileInfo.vue +++ /dev/null @@ -1,104 +0,0 @@ - - - - - diff --git a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ResourceDetails.spec.ts.snap b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ResourceDetails.spec.ts.snap index dfe995ba008..057bbe96dc9 100644 --- a/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ResourceDetails.spec.ts.snap +++ b/packages/web-app-files/tests/unit/components/FilesList/__snapshots__/ResourceDetails.spec.ts.snap @@ -20,7 +20,6 @@ exports[`ResourceDetails component renders resource details correctly 1`] = `
-
diff --git a/packages/web-app-preview/src/App.vue b/packages/web-app-preview/src/App.vue index 437dd31450b..a01ae1f9e4b 100644 --- a/packages/web-app-preview/src/App.vue +++ b/packages/web-app-preview/src/App.vue @@ -17,52 +17,65 @@ @close="closeApp" /> -
- -
- -
-
-
- +
+
+ +
+
+ +
+
+
+ + + +
+ - -
-
@@ -138,6 +151,7 @@ export default defineComponent({ const activeIndex = ref() const cachedFiles = ref([]) + const folderLoaded = ref(false) const sortBy = computed(() => { if (!unref(contextRouteQuery)) { @@ -234,7 +248,12 @@ export default defineComponent({ if (!unref(currentFileContext) || unref(closed)) { return } - await appDefaults.loadFolderForFileContext(unref(currentFileContext)) + + if (!unref(folderLoaded)) { + await appDefaults.loadFolderForFileContext(unref(currentFileContext)) + folderLoaded.value = true + } + instance.proxy.setActiveFile(unref(unref(currentFileContext).driveAliasAndItem)) }, { immediate: true } @@ -367,23 +386,15 @@ export default defineComponent({ } }, loadMedium() { - this.isFileContentLoading = true - - // Don't bother loading if file is already loaded and cached if (this.activeMediaFileCached) { - setTimeout( - () => { - this.isFileContentLoading = false - }, - // Delay to animate - 50 - ) return } this.loadActiveFileIntoCache() }, async loadActiveFileIntoCache() { + this.isFileContentLoading = true + try { const loadRawFile = !this.isActiveFileTypeImage let mediaUrl @@ -533,4 +544,9 @@ export default defineComponent({ margin: 10px auto; } } +@media (max-width: $oc-breakpoint-medium-default) { + .preview-sidebar-open { + display: none; + } +} diff --git a/packages/web-app-preview/src/components/Sources/MediaImage.vue b/packages/web-app-preview/src/components/Sources/MediaImage.vue index 706ab7cf356..854e8de2d1e 100644 --- a/packages/web-app-preview/src/components/Sources/MediaImage.vue +++ b/packages/web-app-preview/src/components/Sources/MediaImage.vue @@ -9,8 +9,8 @@ /> + diff --git a/packages/web-pkg/src/components/SideBar/SideBar.vue b/packages/web-pkg/src/components/SideBar/SideBar.vue index 204f30a2c6e..da9ea11e2dc 100644 --- a/packages/web-pkg/src/components/SideBar/SideBar.vue +++ b/packages/web-pkg/src/components/SideBar/SideBar.vue @@ -94,8 +94,9 @@