From 02b561c4e76120991c7cc7ee88732b1164c4089b Mon Sep 17 00:00:00 2001 From: Paul Neubauer Date: Tue, 16 Jan 2024 14:39:13 +0100 Subject: [PATCH] Fix missing unref --- packages/web-pkg/src/apps/types.ts | 2 +- packages/web-pkg/src/composables/piniaStores/theme.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/web-pkg/src/apps/types.ts b/packages/web-pkg/src/apps/types.ts index be8d2be6cca..2dc3c31b0a6 100644 --- a/packages/web-pkg/src/apps/types.ts +++ b/packages/web-pkg/src/apps/types.ts @@ -91,7 +91,7 @@ export interface ClassicApplicationScript { translations?: ApplicationTranslations extensions?: Ref initialize?: () => void - ready?: (args: AppReadyHookArgs) => void + ready?: (args: AppReadyHookArgs) => Promise | void mounted?: (...args) => void // TODO: move this to its own type setup?: (args: { applicationConfig: AppConfigObject }) => ClassicApplicationScript diff --git a/packages/web-pkg/src/composables/piniaStores/theme.ts b/packages/web-pkg/src/composables/piniaStores/theme.ts index d725079984e..a6a99fae98d 100644 --- a/packages/web-pkg/src/composables/piniaStores/theme.ts +++ b/packages/web-pkg/src/composables/piniaStores/theme.ts @@ -95,14 +95,14 @@ export const useThemeStore = defineStore('theme', () => { setAndApplyTheme( unref(availableThemes).find((t) => t.name === unref(currentLocalStorageThemeName)) || - (isDark ? availableThemes.value[1] : availableThemes.value[0]), + (unref(isDark) ? availableThemes.value[1] : availableThemes.value[0]), false ) } const setAutoSystemTheme = () => { currentLocalStorageThemeName.value = null - setAndApplyTheme(isDark ? availableThemes.value[1] : availableThemes.value[0], false) + setAndApplyTheme(unref(isDark) ? availableThemes.value[1] : availableThemes.value[0], false) } const isCurrentThemeAutoSystem = computed(() => {